Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wins.js so the Wins page uses icon-github.svg #7691

Closed

Conversation

izma-mujeeb
Copy link
Member

Fixes #replace_this_text_with_the_issue_number

What changes did you make?

  • I changed the URL of the github icon to include a svg file

Why did you make the changes (we will use this info to test)?

  • Using a svg file helps a duplicate in the number of images that are being used.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

Copy link

github-actions bot commented Nov 5, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b izma-mujeeb-update-svg-file-6911 gh-pages
git pull https://github.com/izma-mujeeb/website.git update-svg-file-6911

@izma-mujeeb izma-mujeeb marked this pull request as draft November 5, 2024 01:50
@izma-mujeeb izma-mujeeb closed this Nov 5, 2024
@izma-mujeeb izma-mujeeb deleted the update-svg-file-6911 branch November 5, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant