Update Project Profile - Add Aditya Profile to guides-team.md #7685
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
eta: Nov 5th, 2024 11:59pm PST |
|
Review ETA: 11/4/2024 Monday |
There was a problem hiding this comment.
Great job on your second good first issue, @trimakichan !
You have been improving since your first good first issue.
- Availability and ETA are included in the original issue
- The Linked issue number is included
- The branch you work on is accurate
- The change you made is correct
- CodeQL alerts are checked
- Before-and-after screenshots are listed
Improvements:
- Name the branch with more specific details, for example, project name + add/remove + volunteer's name + linked issue number
- Leave the checkboxes empty, you can check the corresponding checkbox after submitting the comment/PR
Keep it up and thank you for your contribution!
|
Review ETA: 8 AM 11/3/2024 |
There was a problem hiding this comment.
Great job on the pull request, @trimakichan!
- Branches are set up correctly
- Correct issue is linked
- Reason for changes is clear
- Visual changes are clear
There was a problem hiding this comment.
@trimakichan Great Job on this issue!
- You made the correct changes
- The description is very detailed and concise
- The issue is linked correctly
Keep it up!
There was a problem hiding this comment.
Hi @trimakichan,
Great job!
- changes made and why they were made are stated clearly
- branch naming is correct
- CodeQL check was done
- visual changes were shown
Thanks for your contribution!
|
Hi @trimakichan Please resolve the merge conflict below. In case you have not seen this before: An issue related to yours (#7584) was merged, so now you need to update your branch before your PR can be merged. It is pretty straightforward- you can do it manually by clicking "Resolve conflicts". Let us know if you have any questions. Thanks! |
trimakichan
dismissed stale reviews from terrencejihoonjung, codyyjxn, maadeshsivakumar, and siyunfeng
via
305696e
Thank you for reviewing my PR, @siyunfeng! Could you tell me which checkboxes you are referring to? Thanks! |
Thank you for letting me know, @t-will-gillis! I just resolved the conflict. Thanks! |
|
Hey @trimakichan Thanks for resolving the merge conflict! @terrencejihoonjung @codyyjxn @maadeshsivakumar @siyunfeng Please do a final check and re-Approve now that the merge conflict is resolved. Thank you! |
t-will-gillis
requested review from
maadeshsivakumar,
terrencejihoonjung,
siyunfeng and
codyyjxn
You did well fixing it. It was the |
There was a problem hiding this comment.
Thank you for working on this issue, @trimakichan !
You did well fixing what I mentioned and everything looks good.
There was a problem hiding this comment.
@trimakichan Thank you for taking on this issue. Great job on fixing the merge conflict.
Fixes #7585
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied