Replace label in project-profile-card-review-and-update.yml #7606

[ihop-56]

Fixes #7606

What changes did you make?

• Updated the issue template to replace ready for dev lead with ready for merge team in the project-profile-card-review-and-update.yml file.

Why did you make the changes (we will use this info to test)?

• The change was requested to streamline issue review processes, allowing the merge team to handle more issue reviews effectively.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

• I have checked this PR for CodeQL alerts and none were found.
• I found CodeQL alert(s), and (select one):
  • I have resolved the CodeQL alert(s) as noted
  • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
  • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

For Reviewers

• Use this URL to check the updated issue template: [https://github.com/Update Project Profile: [Project Name] ihop-56/website#2]

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

• No visual changes to the website

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b ihop-56-replace-label-in-project-profile-card-7606 gh-pages
git pull https://github.com/ihop-56/website.git replace-label-in-project-profile-card-7606

[dcotelessa]

ETA: 1 hour
Availability: 4-6 W Th F

[codyyjxn]

ETA: EOD
Availability: M > F

[dcotelessa]

Good job!

• project-profile-card-review-and-update template label was updated.
• No new CodeQL errors.
• Straightforward label image change.

[siyunfeng]

Review ETA: 11/1/2024 Friday
Availability: 7-10 PM Weekdays (EDT)

[siyunfeng]

Thank you for working on this issue, @ihop-56 !

The branch you work on is accurate. I appreciate you provided your ETA and availability in the original issue, and included the original issue number in this PR. I'd suggest removing the extra space before the context you replaced by following the existing syntax of the front matter block in the file.

Before making the change, you may need to ensure your branch is up to date. The issue template is Project Profile Card review and update according to the project-profile-card-review-and-update.yml file.

• Please provide the correct issue template creation URL and update it to the For Reviewers section without creating the issue.

You may need to create new labels from your GitHub if you don't see the corresponding labels in the project-profile-card-review-and-update.yml file shown in the template.

Project Profile Card review and update template

[codyyjxn]

@ihop-56
Things that went well:

• You made the correct changes
• The description is very detailed and concise
• The issue is linked correctly

Things that need to be improved

• Please fix the For Reviewers section. The url that is provided is not properly set.

[siyunfeng]

Hi @ihop-56 , please make the changes we requested. Feel free to reach out if you have any questions.

[ihop-56]

Hi @siyunfeng and team, the requested changes have been made:

• Fixed the extra space in the syntax to align with the existing front matter block.
• I'm not sure how to update the "For Reviewers" section with the correct issue template URL. Could you please help me with this?

[t-will-gillis]

Hello @ihop-56 Please provide an update on when you will be able to wrap up this PR.
Thanks

[ihop-56]

Hello @ihop-56 Please provide an update on when you will be able to wrap up this PR. Thanks

End of this week

[siyunfeng]

Hi @siyunfeng and team, the requested changes have been made:

• Fixed the extra space in the syntax to align with the existing front matter block.
• I'm not sure how to update the "For Reviewers" section with the correct issue template URL. Could you please help me with this?

Fixed the extra space in the syntax to align with the existing front matter block.

I still can see the extra spaces in line 353.

I'm not sure how to update the "For Reviewers" section with the correct issue template URL. Could you please help me with this?

The file you made the change on was .github/ISSUE_TEMPLATE/project-profile-card-review-and-update.yml. Its corresponding issue template should be Project Profile Card review and update, and the issue template you used was Project Profile leader updates - Add.

I don't see the Project Profile Card review and update issue template in your repo, it could be an issue from when you forked from the original repo.

[ihop-56]

@siyunfeng Hi, Can you check again? I have fixed the extra space and I'm not able to find the Project Profile Card review and update template in my repo

[siyunfeng]

@siyunfeng Hi, Can you check again? I have fixed the extra space and I'm not able to find the Project Profile Card review and update template in my repo

Hi @ihop-56 , I can see the Project Profile Card review and update issue template in your repo.

• Complete the CodeQL Alerts section

  Screenshot of CodeQL Alerts

  

• Double-check your template, and ensure the changes apply to the updated template

• Update the correct template URL in the For Reviewers section (No need to create an issue)

Because the original issue is missing the instructions for creating corresponding labels for the template, you will need to complete this PR with the following steps:

• Browse to the Issues page in your repo, then click Labels

  Screenshot of Labels Setting

  

• Create labels corresponding to each label that was listed in the updated issue template. The color of the labels doesn't have to match those on the hackforla/website repository, but the text of the labels must match exactly.

  Screenshot of Creating New Label

  
  

Once you create all the labels listed in the file /.github/ISSUE_TEMPLATE/project-profile-card-review-and-update.yml in your repo, you should be able to see the corresponding labels appear in the updated issue template.

You can re-request me to review your PR once you complete the steps above.

[ihop-56]

@siyunfeng I'm not sure how to do this. Can I take up a new issue to work on?

[siyunfeng]

@siyunfeng I'm not sure how to do this. Can I take up a new issue to work on?

Hi @ihop-56 , you can follow the steps from my previous comment and you should be able to resolve it. Don't hesitate to comment on this PR if you have any questions.

[siyunfeng]

Hi @ihop-56 , please provide an update on when you can wrap up this PR.

[mchait18]

Review ETA: 12 PM EST 12/11/24
Availability: 10-3 EST Mon-Thurs

[mchait18]

Hello @ihop-56 ,
Things you did well:

• The code changes look good
• The issue is linked correctly
• The description is clear and concise

Things you need to chane:

• Check off the CodeQL alerts section
• as @siyunfeng mentioned, the URL is pointing to the wrong Issue creation page. It needs to create the project-profile-card-review-and-update issue, not the Update Project Profile - Add issue. Therefore the labels are incorrect as well. As soon as you correct these changes, I'll be happy to re-review!

[ihop-56]

Hi @siyunfeng, I created a new issue template as you described above. Can you pls check if I have done it right?

[siyunfeng]

Hi @siyunfeng, I created a new issue template as you described above. Can you pls check if I have done it right?

@ihop-56 , as I mentioned in the previous comment, you don't need to create a new issue.

I can see the correct issue template in your repo, please update the Project Profile Card review and update issue template URL to the For Reviewers section.

Please carefully read the comment and complete all the steps.

I'll be happy to review it once you're done.