Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to check for the specified main HFLA website repository before commencing scheduling workflow. #7634

Conversation

srinipandiyan
Copy link
Member

@srinipandiyan srinipandiyan commented Oct 25, 2024

Fixes #7500

What changes did you make?

  • Added an if-conditional statement to schedule-fri-0700.yml which commences the workflow after checking for the specified main hackforla/website repository.

Why did you make the changes (we will use this info to test)?

  • Previously the scheduling workflow could be run from any individual user's repository, which could be a nuisance or cause confusion.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b srinipandiyan-refactor-friday-schedule-yml-to-run-on-HFLA-repo-7500 gh-pages
git pull https://github.com/srinipandiyan/website.git refactor-friday-schedule-yml-to-run-on-HFLA-repo-7500

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 25, 2024
Copy link
Member

@kabszac kabszac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srinipandiyan kindly move the status from prioritized backlog to In progress on the issue page.

@kabszac
Copy link
Member

kabszac commented Oct 25, 2024

Availability: 5-7pm, Mon-Fri
ETA: EOD Saturday, Oct 26

@srinipandiyan
Copy link
Member Author

@kabszac done!

@codyyjxn codyyjxn self-requested a review October 25, 2024 16:44
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srinipandiyan Thank you for taking on this issue.

  • You made the correct changes
  • The description is very detailed and concise
  • The issue is linked correctly

Keep up the good work!

@siyunfeng siyunfeng self-requested a review October 25, 2024 18:18
@siyunfeng
Copy link
Member

Review ETA: 10/25/2024
Availability: 6-10 PM Weekdays (EDT)

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @srinipandiyan !

  • Availability and ETA are posted in the original issue
  • Changes are accurate
  • Branch is correct, linked issue is included

Thank you for working on this issue!

Copy link
Member

@kabszac kabszac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srinipandiyan Great Job! You made the correct changes
Keep up the good work!

@t-will-gillis t-will-gillis merged commit f69f164 into hackforla:gh-pages Oct 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Refactor "Schedule Friday" workflow trigger to run only on HfLA repo
5 participants