Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 'update-label-directory.yml' and 'update-label-directory.js' #7599

Conversation

theogguu
Copy link
Member

@theogguu theogguu commented Oct 19, 2024

Fixes #7563

What changes did you make?

Why did you make the changes (we will use this info to test)?

  • To keep the update-label-directory.yml workflow up to date

No visual changes to the website.

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours labels Oct 19, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b theogguu-maintenance-for-update-label-dir-workflow-7563 gh-pages
git pull https://github.com/theogguu/website.git maintenance-for-update-label-dir-workflow-7563

@t-will-gillis t-will-gillis self-requested a review October 21, 2024 16:05
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @theogguu Everything looks good-

  • Branches are good
  • Link to the original issue
  • Descriptions for what was changed and why
  • Code changes are clean

Great job and thanks for working on this!

@siyunfeng siyunfeng self-requested a review October 21, 2024 20:05
@siyunfeng
Copy link
Member

Review ETA: 10/22/2024
Availability: 6:00 PM - 10:00 PM Weekdays (EDT)

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @theogguu !

  • Branch name is clear
  • Linked issue is included
  • Availability and ETA are posted in the original issue
  • Changes are accurate according to the original issue

Thank you for your contribution!

@daras-cu daras-cu merged commit 0f877e9 into hackforla:gh-pages Oct 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours
Projects
Development

Successfully merging this pull request may close these issues.

Maintenance for "Update Label Directory" workflow
4 participants