-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: VRMS Add Jack Haeger #7592
Update Project Profile: VRMS Add Jack Haeger #7592
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
The new profile is added correctly in the code base and the new profile card populates on the VRMS project page like it should.
Provided a good explanation as to why the changes were made and visuals for before and after.
My only suggestion is to be more specific with your git branch naming in the future. In this case, it would allow us to quickly know the profile is being added to the VRMS project specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theogguu Great job on your Good First Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/vrms.md
was edited - No extra edits were made
- Appearance of the website looks just like your screenshots (Chrome and Firefox)
- I agree with the nitpick from the other reviewer: naming your issue branch so that which project was modified is in the name would be more clear.
Approved! 👍
Hey! Your pull request looks good!
Other than a clearer branch name like the others mentioned, everything looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theogguu Great job on your Good first issue.
Things that went well:
- The correct branch name
- The correct file _projects/vrms.md was edited
- You provided screenshots
- Set this up in my end I was able to see what the changes you made.
Keep it up!
Great Job @theogguu,
|
Fixes #7473
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied