Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Ida Valenzuela as leadership for Civic Tech Jobs #7579

Merged

Conversation

siyunfeng
Copy link
Member

@siyunfeng siyunfeng commented Oct 10, 2024

Fixes #7555

What changes did you make?

  • updated leadership info for Civic Tech Jobs (added Ida Valenzuela)

Why did you make the changes (we will use this info to test)?

  • to ensure the leadership info for project Civic Tech Jobs is up-to-date

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied
Visuals after changes are applied

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b siyunfeng-update-project-profile-7555 gh-pages
git pull https://github.com/siyunfeng/hackforla-website.git update-project-profile-7555

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 10, 2024
@ramitaarora ramitaarora self-requested a review October 10, 2024 04:14
@ramitaarora
Copy link
Member

Availability: Weekday mornings
ETA: Thurs Oct 10

Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

  • You made the pull request from the correct branch
  • I see the changes in the IDE
  • The changes are correctly reflected on the civic tech jobs projects page
  • One improvement is that you can have a better branch name, such as added-ida-valenzuela-leadership-profile-7555

Nice work, and thank you for your contribution!

@codyyjxn codyyjxn self-requested a review October 10, 2024 18:28
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @siyunfeng on your first issue! The changes look good, the branch is named correctly, and the title is clear. I also appreciate the before-and-after screenshots, as they effectively illustrate what has been changed.

For the section Why did you make the changes (we will use this info to test)?, I recommend providing an explanation of why this change was necessary. Usually, the original issue should give some context for this. Additionally, it would be helpful if you could address the question posed by the bot in the comments section of the original issue.

Other than that, excellent work, and thank you for your contributions! Keep it up!

@siyunfeng
Copy link
Member Author

Looks great!

  • You made the pull request from the correct branch
  • I see the changes in the IDE
  • The changes are correctly reflected on the civic tech jobs projects page
  • One improvement is that you can have a better branch name, such as added-ida-valenzuela-leadership-profile-7555

Nice work, and thank you for your contribution!

Thank you, Ramita! I'll name the branch with more specific details next time.

@siyunfeng
Copy link
Member Author

Great job @siyunfeng on your first issue! The changes look good, the branch is named correctly, and the title is clear. I also appreciate the before-and-after screenshots, as they effectively illustrate what has been changed.

For the section Why did you make the changes (we will use this info to test)?, I recommend providing an explanation of why this change was necessary. Usually, the original issue should give some context for this. Additionally, it would be helpful if you could address the question posed by the bot in the comments section of the original issue.

Other than that, excellent work, and thank you for your contributions! Keep it up!

Thank you, @codyyjxn! I updated the answer to Why did you make the changes (we will use this info to test)? and left a comment for Availability and ETA in the original issue according to your advice.

@t-will-gillis t-will-gillis merged commit c913beb into hackforla:gh-pages Oct 13, 2024
11 checks passed
@siyunfeng siyunfeng deleted the update-project-profile-7555 branch October 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Add Ida Valenzuela
4 participants