-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Ida Valenzuela as leadership for Civic Tech Jobs #7579
added Ida Valenzuela as leadership for Civic Tech Jobs #7579
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: Weekday mornings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
- You made the pull request from the correct branch
- I see the changes in the IDE
- The changes are correctly reflected on the civic tech jobs projects page
- One improvement is that you can have a better branch name, such as added-ida-valenzuela-leadership-profile-7555
Nice work, and thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @siyunfeng on your first issue! The changes look good, the branch is named correctly, and the title is clear. I also appreciate the before-and-after screenshots, as they effectively illustrate what has been changed.
For the section Why did you make the changes (we will use this info to test)?
, I recommend providing an explanation of why this change was necessary. Usually, the original issue should give some context for this. Additionally, it would be helpful if you could address the question posed by the bot in the comments section of the original issue.
Other than that, excellent work, and thank you for your contributions! Keep it up!
Thank you, Ramita! I'll name the branch with more specific details next time. |
Thank you, @codyyjxn! I updated the answer to |
Fixes #7555
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied