Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wins.js so the Wins page uses icon-github.svg #7569

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Update wins.js so the Wins page uses icon-github.svg #7569

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf6a2aa
update wins.js so the Wins page uses icon-github.svg
izma-mujeeb Oct 8, 2024
bc70186
fix svg file
izma-mujeeb Nov 5, 2024
0cabf1e
fixed html and svg files to ensure icon is being display properly
izma-mujeeb Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions assets/images/wins-page/icon-github-small.svg
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions assets/js/wins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
const cardTemplate = document.getElementById("wins-card-template");
const QUOTE_ICON_PATH = '/assets/images/wins-page/quote-icon.svg'
const AVATAR_DEFAULT_PATH = "/assets/images/wins-page/avatar-default.svg"
const GITHUB_ICON = '/assets/images/wins-page/icon-github-small.svg';
const GITHUB_ICON = `{% include svg/icon-github.svg %}`;
const LINKEDIN_ICON = '/assets/images/wins-page/icon-linkedin-small.svg'
const winsCardContainer = document.querySelector('#responses');

Expand Down Expand Up @@ -330,7 +330,7 @@

if (card[github_url].length > 0){
cloneCardTemplate.querySelector('.wins-card-github-icon').href = card[github_url];
cloneCardTemplate.querySelector('.github-icon').src = GITHUB_ICON ;
cloneCardTemplate.querySelector('.github-icon').src = GITHUB_ICON;
Copy link
Member

@roslynwythe roslynwythe Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izma-mujeeb The liquid statement {% include svg/icon-github.svg %} will result in an inline svg, which should replace the existing img tag. To accomplish this, I think you will want to make changes to both wins.js and the html template (_includes/wins-page/wins-card-template.html/wins-card-template.html). I should have mentioned that in the issue. I added an Action Item and Resources to the issue, to clarify.

Part of the issue is making the svg accessible. The Resource making SVGs WCAG compliant provides sample code for doing that.

We could setup a Zoom meeting to go over this, or we could discuss it in the Thursday office hours. Please send me a Slack message and let me know your availability. If you would like to meet, please send me a Slack message.

cloneCardTemplate.querySelector('.github-icon').alt = `Github profile for ${card[name]}`;
} else {
cloneCardTemplate.querySelector('.wins-card-github-icon').setAttribute('hidden', 'true')
Expand Down Expand Up @@ -506,7 +506,7 @@ function changeSeeMoreBtn(x) {
if (data[i][linkedin_url].length > 0) {
makeIcon(data[i][linkedin_url], overlayIcons, 'linkedin-icon', '/assets/images/wins-page/icon-linkedin-small.svg', 'LinkedIn profile for ' + data[i][name]);
} if (data[i][github_url].length > 0) {
makeIcon(data[i][github_url], overlayIcons, 'github-icon', '/assets/images/wins-page/icon-github-small.svg', 'Github profile for ' + data[i][name]);
makeIcon(data[i][github_url], overlayIcons, 'github-icon', `{% include svg/icon-github.svg %}`, 'Github profile for ' + data[i][name]);
}

const overlayName = document.querySelector('#overlay-name');
Expand Down