-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace github with GitHub in CONTRIBUTING.md #7558
Replace github with GitHub in CONTRIBUTING.md #7558
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Availability: M > F |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jenjenkayi,
Thank you for taking on this issue!
Things that went well:
- The branch is named correctly
- The issue is linked.
- The title and description are concise and clear.
The only change:
- The only suggestion I have is to remove the brackets around the link in the section where you provided the changes. Everything else looks great!
Availability: 5pm-9pm M -F |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jenjenkayi, thanks for taking on this issue!
Things you did well:
- Branch name contains issue number
- PR title, description, & reason are informative & concise
- Issues action items properly followed
Things to Work on:
- Small oversight but branch name has Github instead of GitHub
- Visual changes not included. The CONTRIBUTING.md on the main repo is different.
- review link is not done correctly. I recommend you re-read the last action item as to how you can fix it!
Once you fix these issues, please request a re-review and I'll gladly approve the PR. Thanks!
Thank you for your comments.
|
Correct, before we push the changes to the main branch it's best to see what is different visually between the current site at "https://www.hackforla.org/" and the one on your branch. In this case, compare https://github.com/jenjenkayi/website/blob/replace-github-with-Github-7442/CONTRIBUTING.md to https://github.com/jenjenkayi/website/blob/gh-pages/CONTRIBUTING.md. |
Sorry about that, you are correct! It is not on the main website so it does not need to be included. Thank you for making all the required changes! |
Fixes #7442
What changes did you make?
Why did you make the changes (we will use this info to test)?
For Reviewers: Do not review changes locally, rather, review changes at https://github.com/jenjenkayi/website/blob/replace-github-with-Github-7442/CONTRIBUTING.md
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)