Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github with GitHub in CONTRIBUTING.md #7558

Merged

Conversation

jenjenkayi
Copy link
Member

@jenjenkayi jenjenkayi commented Oct 2, 2024

Fixes #7442

What changes did you make?

  • Replace github with GitHub in CONTRIBUTING.md Section 2.7.f ii

Why did you make the changes (we will use this info to test)?

  • So that we display the company name correctly

For Reviewers: Do not review changes locally, rather, review changes at https://github.com/jenjenkayi/website/blob/replace-github-with-Github-7442/CONTRIBUTING.md

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website.

Copy link

github-actions bot commented Oct 2, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jenjenkayi/website/blob/replace-github-with-Github-7442/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Oct 2, 2024
@codyyjxn codyyjxn self-requested a review October 2, 2024 23:45
@codyyjxn
Copy link
Member

codyyjxn commented Oct 3, 2024

Availability: M > F
ETA: EOD

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jenjenkayi,
Thank you for taking on this issue!

Things that went well:

  • The branch is named correctly
  • The issue is linked.
  • The title and description are concise and clear.

The only change:

  • The only suggestion I have is to remove the brackets around the link in the section where you provided the changes. Everything else looks great!

@FamousHero FamousHero self-requested a review October 3, 2024 23:42
@FamousHero
Copy link
Member

Availability: 5pm-9pm M -F
ETA: EOD 10/5

Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jenjenkayi, thanks for taking on this issue!

Things you did well:

  • Branch name contains issue number
  • PR title, description, & reason are informative & concise
  • Issues action items properly followed

Things to Work on:

  • Small oversight but branch name has Github instead of GitHub
  • Visual changes not included. The CONTRIBUTING.md on the main repo is different.
  • review link is not done correctly. I recommend you re-read the last action item as to how you can fix it!

Once you fix these issues, please request a re-review and I'll gladly approve the PR. Thanks!

@jenjenkayi jenjenkayi closed this Oct 7, 2024
@jenjenkayi jenjenkayi reopened this Oct 7, 2024
@jenjenkayi jenjenkayi closed this Oct 7, 2024
@jenjenkayi jenjenkayi deleted the replace-github-with-Github-7442 branch October 7, 2024 21:19
@jenjenkayi
Copy link
Member Author

@FamousHero

Thank you for your comments.

  1. The branch name is fixed.
  2. Since there are no visual changes to the website, I did not include the screenshots of the code changes.
    The changes are on the "replace-github-with-Github-7442" branch. I am not sure what you meant by saying the main repo is different.
  3. I have removed the brackets per the instructions.

@jenjenkayi jenjenkayi restored the replace-github-with-Github-7442 branch October 7, 2024 21:26
@jenjenkayi jenjenkayi reopened this Oct 7, 2024
@jenjenkayi jenjenkayi requested a review from FamousHero October 7, 2024 21:28
@FamousHero
Copy link
Member

2. The changes are on the "replace-github-with-Github-7442" branch. I am not sure what you meant by saying the main repo is different.

Correct, before we push the changes to the main branch it's best to see what is different visually between the current site at "https://www.hackforla.org/" and the one on your branch. In this case, compare https://github.com/jenjenkayi/website/blob/replace-github-with-Github-7442/CONTRIBUTING.md to https://github.com/jenjenkayi/website/blob/gh-pages/CONTRIBUTING.md.

@FamousHero
Copy link
Member

  1. The changes are on the "replace-github-with-Github-7442" branch. I am not sure what you meant by saying the main repo is different.

Correct, before we push the changes to the main branch it's best to see what is different visually between the current site at "https://www.hackforla.org/" and the one on your branch. In this case, compare https://github.com/jenjenkayi/website/blob/replace-github-with-Github-7442/CONTRIBUTING.md to https://github.com/jenjenkayi/website/blob/gh-pages/CONTRIBUTING.md.

Sorry about that, you are correct! It is not on the main website so it does not need to be included. Thank you for making all the required changes!

@Thinking-Panda Thinking-Panda merged commit a3d8170 into hackforla:gh-pages Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Replace github with GitHub in CONTRIBUTING.md Section 2.7.f ii
4 participants