Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Current Project Team Contributors in Civic Tech Jobs Profile Page #7543

Closed
wants to merge 1 commit into from
Closed

Updated Current Project Team Contributors in Civic Tech Jobs Profile Page #7543

wants to merge 1 commit into from

Conversation

floydferrer
Copy link
Member

Fixes #7521

What changes did you make?

  • Added Ida Valenzuela and Kevin Yu to the Current Project Team section of the Civic Tech Jobs project page
  • Please note the Issue also requested the removal of Peter Olorunsola and Anahis Valenzuela but these members were already removed

Why did you make the changes (we will use this info to test)?

  • Updated so that the current team members can be properly displayed on the Civic Tech Jobs project page

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2024-09-29 150355

Visuals after changes are applied

Screenshot 2024-09-29 154146

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b floydferrer-update-project-profile-7521 gh-pages
git pull https://github.com/floydferrer/website.git update-project-profile-7521

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe epic size: 0.25pt Can be done in 0.5 to 1.5 hours Issue Making: Level 1 Make issues from a template and a spreadsheet Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level labels Sep 29, 2024
@codyyjxn codyyjxn self-requested a review September 30, 2024 02:21
codyyjxn
codyyjxn approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @floydferrer great job on your first good issue. The branch name is correct and the changes are clear. Also the screenshots are a perfect visual for anyone to understand what was changed. You also created the other two issues which look good as well.

@codyyjxn
Copy link
Member

Availability: M > S
ETA: EOD

@t-will-gillis
Copy link
Member

t-will-gillis commented Sep 30, 2024 •
edited
Loading

Hi @floydferrer I left notes on Slack also: I am closing this because although the changes are correct and ultimately what we need, the issue flow should be:

Thank you for creating the issues, and when they are prioritized feel free to work on one or the other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyyjxn codyyjxn codyyjxn approved these changes

Assignees
No one assigned
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level epic good first issue Good for newcomers Issue Making: Level 1 Make issues from a template and a spreadsheet P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs
3 participants
@floydferrer @codyyjxn @t-will-gillis