Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub-handle for Brett Beekley in hellogov.md #7529

Merged

Conversation

Sujay-Anantha
Copy link
Member

@Sujay-Anantha Sujay-Anantha commented Sep 27, 2024

Fixes #7403

What changes did you make?

  • Added github-handle for Brett Beekley in hellogov.md

Why did you make the changes (we will use this info to test)?

  • Added to eventually replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Sujay-Anantha-add-github-handle-7403 gh-pages
git pull https://github.com/Sujay-Anantha/website.git add-github-handle-7403

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 27, 2024
@codyyjxn codyyjxn self-requested a review September 27, 2024 17:44
@codyyjxn
Copy link
Member

Availability: Mon > Fri
ETA: EOD

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the things that are correct:

-The branch name is accurate.
-The title clearly states the change made.
-The description is concise and explains what was changed and why.

However, a few adjustments are needed:

  • The change you made is almost correct, but you need to remove the name added to the github-handle. The original issue only requires the github-handle: variable, not the name "Beekley."

  • In the section asking for a screenshot, you don’t need to add a comment. That section is meant only for screenshots, so you can simply note "No visual changes.""

@Sujay-Anantha
Copy link
Member Author

I have updated it as requested. Please let me know if any other changes/updates have to be made.
Thank you

@codyyjxn
Copy link
Member

Hi @Sujay-Anantha great job! The changes are good. Please re-request a review.

@FamousHero FamousHero self-requested a review September 28, 2024 02:57
Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sujay-Anantha, thanks for taking on this issue!

Things you did well:

  • descriptive branch name with issue number included
  • Issue # properly linked in PR
  • PR title gives a good overview of what PR does
  • Changes made is short & descriptive
  • Why you made the changes is clear

No reviews needed, good job!

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! @Sujay-Anantha

@t-will-gillis t-will-gillis self-requested a review September 29, 2024 16:50
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sujay-Anantha Great job on your first HfLA PR- branches are good, you are linked to the issue, and your description for what was done and why is clear and concise. Thanks for working with the other reviewers on changes

@t-will-gillis t-will-gillis merged commit 271a82e into hackforla:gh-pages Sep 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Brett Beekley in hellogov.md
4 participants