-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GitHub-handle for Brett Beekley in hellogov.md #7529
Added GitHub-handle for Brett Beekley in hellogov.md #7529
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: Mon > Fri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the things that are correct:
-The branch name is accurate.
-The title clearly states the change made.
-The description is concise and explains what was changed and why.
However, a few adjustments are needed:
-
The change you made is almost correct, but you need to remove the name added to the
github-handle
. The original issue only requires thegithub-handle:
variable, not the name "Beekley." -
In the section asking for a screenshot, you don’t need to add a comment. That section is meant only for screenshots, so you can simply note "No visual changes.""
I have updated it as requested. Please let me know if any other changes/updates have to be made. |
Hi @Sujay-Anantha great job! The changes are good. Please re-request a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Sujay-Anantha, thanks for taking on this issue!
Things you did well:
- descriptive branch name with issue number included
- Issue # properly linked in PR
- PR title gives a good overview of what PR does
- Changes made is short & descriptive
- Why you made the changes is clear
No reviews needed, good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! @Sujay-Anantha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sujay-Anantha Great job on your first HfLA PR- branches are good, you are linked to the issue, and your description for what was done and why is clear and concise. Thanks for working with the other reviewers on changes
Fixes #7403
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)