Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the leadership variable with the current team in communities/ops.yml #7504

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

NolaDodd
Copy link
Member

Fixes #7497

What changes did you make?

  • Removed the original "leadership" variable in website_data\internal\communities\ops.yml
  • Replaced it with the new "leadership" variable as specified in the original Issue.

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information. These changes will help visitors find the most updated DevOps team on the Communities of Practice page.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2024-09-19 142506

Visuals after changes are applied

Screenshot 2024-09-19 142751

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b NolaDodd-add-remove-leaders-7497 gh-pages
git pull https://github.com/NolaDodd/website.git add-remove-leaders-7497

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 21, 2024
@FamousHero FamousHero self-requested a review September 21, 2024 19:50
Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NolaDodd, thanks for taking on this issue!

Things you did great:

  • Screenshots accurately show changes from current site to proposed changes
  • Correctly linked issue in PR
  • Accurate description of changes made w/ reference to file location
  • Excellent description of why you made these changes

Things to work on:

  • More descriptive branch name. The currently name makes unclear whether you're adding or removing something.

I don't believe you can change the branch name once a PR is submitted so it's fine this time. Besides that everything looks good!

@codyyjxn codyyjxn self-requested a review September 21, 2024 20:34
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NolaDodd Great Job!
Thank you for making those changes!

@t-will-gillis t-will-gillis merged commit 7e97bb2 into hackforla:gh-pages Sep 23, 2024
6 checks passed
@NolaDodd NolaDodd deleted the add-remove-leaders-7497 branch September 23, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update CoP: Ops: Add and Remove leaders
4 participants