Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github to GitHub in _data/internal/communities/ops.yml #7468

Conversation

buneeIsSlo
Copy link
Member

Fixes #7415

What changes did you make?

  • Replaced - name: Github with - name: GitHub in _data/internal/communities/ops.yml

Why did you make the changes (we will use this info to test)?

  • To display the company name correctly throughout the website.

Screenshots of Proposed Changes to the Website

  • No visual changes

Test

  • Since the link - name: GitHub is not directly referenced in any files, there should be no visual changes.
  1. Follow the steps from How to review Pulll requests section to view the changes locally.
  2. Compare the Ops card on the local website at http://localhost:4000/communities-of-practice to the live website at http://www.hackforla.org/communities-of-practice and verify that there are no differences.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b buneeIsSlo-replace-Github-with-GitHub-in-ops.yml-7415 gh-pages
git pull https://github.com/buneeIsSlo/website.git replace-Github-with-GitHub-in-ops.yml-7415

@buneeIsSlo buneeIsSlo changed the title Update link Github to GitHub in _data/internal/communities/ops.yml Update Github to GitHub in _data/internal/communities/ops.yml Sep 17, 2024
@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 1pt Can be done in 4-6 hours labels Sep 17, 2024
@codyyjxn codyyjxn self-requested a review September 18, 2024 00:43
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buneeIsSlo Good Job on taking on this issue. Tested the changes and didn't see any changes from the live server to the test server.

@ramitaarora ramitaarora self-requested a review September 18, 2024 02:15
@Thinking-Panda
Copy link
Member

@ramitaarora Whenever you get a chance, please add your Availability and ETA. TIA!

@ramitaarora
Copy link
Member

Availability: Weekday mornings
ETA: Sept 20

@vorleakyek vorleakyek self-requested a review September 20, 2024 02:56
Copy link
Member

@vorleakyek vorleakyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Verified that there are no visual changes for the "View GitHub" button on the Communities of Practice page. Thanks for working on this!

Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

  • You made the request from the correct branch
  • I see the changed spelling of GitHub in _data/internal/communities/ops.yml
  • There are no visual changes to the Communities of Practice page

Thank you for your contribution :)

@t-will-gillis t-will-gillis merged commit 81a9d4b into hackforla:gh-pages Sep 22, 2024
8 checks passed
@buneeIsSlo buneeIsSlo deleted the replace-Github-with-GitHub-in-ops.yml-7415 branch December 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in _data/internal/communities/ops.yml
6 participants