-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github to GitHub in _data/internal/communities/ops.yml
#7468
Update Github to GitHub in _data/internal/communities/ops.yml
#7468
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
_data/internal/communities/ops.yml
_data/internal/communities/ops.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buneeIsSlo Good Job on taking on this issue. Tested the changes and didn't see any changes from the live server to the test server.
@ramitaarora Whenever you get a chance, please add your Availability and ETA. TIA! |
Availability: Weekday mornings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Verified that there are no visual changes for the "View GitHub" button on the Communities of Practice page. Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
- You made the request from the correct branch
- I see the changed spelling of GitHub in _data/internal/communities/ops.yml
- There are no visual changes to the Communities of Practice page
Thank you for your contribution :)
Fixes #7415
What changes did you make?
- name: Github
with- name: GitHub
in_data/internal/communities/ops.yml
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes to the Website
Test
- name: GitHub
is not directly referenced in any files, there should be no visual changes.Ops
card on the local website at http://localhost:4000/communities-of-practice to the live website at http://www.hackforla.org/communities-of-practice and verify that there are no differences.