-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paragraphs alignment in the About Us and Join Us pages #7467
Fix paragraphs alignment in the About Us and Join Us pages #7467
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vorleakyek Making similar changes to the .sub-p
class in _containers.scss
and adding styles for @media #{$bp-below-tablet}
viewport will achieve the desired results. Let me know in case you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vorleakyek Thank you for taking on this issue.
Great branch name.
Title is clear and description as well.
Screenshots before and after are great!
Thanks for the suggestion @Thinking-Panda! I modified the Thanks @codyyjxn for starting to take a look. |
e6d7995
to
d96d05d
Compare
Hi @Thinking-Panda and @codyyjxn, please take another look at my PR and let me know if there is anything that I should change. |
Hello @Thinking-Panda and @codyyjxn Please let us know when you will be able to re-review the changes made by @vorleakyek. Thank you! |
Availability: M-Th 10-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vorleakyek Merge branches are set up correct. Changes are as mentioned in the issue producing desired result in all pages and in all viewports. Well done. Approved!
Fixes #7304
What changes did you make?
width: 100%
property under.sub-p
in the_sass/elements/_containers.scss
file.Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals Before and After the changes for the Join Us page
Visuals Before and After the changes for the About Us page