Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the label that is added when dev attempts to open multiple issues #7466

Merged

Conversation

izma-mujeeb
Copy link
Member

Fixes #7300

What changes did you make?

  • I added three main changes for this issue. I changed the variable name of "ready for dev lead" with the variable of "ready for prioritization". I then had to change any code that utilized the previous variable with the new variable. Lastly, I had to change JSDoc comment to better reflect the description of the new variable.

Why did you make the changes (we will use this info to test)?

  • The main purpose of this change was to make it easier when a developer self-assigns an issue, when they are already working on an issue that hasn't been completed or merged. Typically, when a developer assigns an issue and they are still working on an another issue, the "Issue Trigger" workflow is triggered. This trigger un-assigns the developer from the second issue and moves it to the "New Issue Approval" column and applies the ready for dev lead label. We need the trigger to apply the ready for prioritization label instead, so that Bonnie can re-prioritize the issue as appropriate. This issue helps with applying the correct labels to the issue.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b izma-mujeeb-open-multiple-issues-attempt-7300 gh-pages
git pull https://github.com/izma-mujeeb/website.git open-multiple-issues-attempt-7300

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Sep 17, 2024
@k-cardon k-cardon self-requested a review September 17, 2024 21:06
Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The one change I've requested is to remove the comment on line 81, for clarity; otherwise everything looks in order and I confirmed no visual changes to site.

@8alpreet
Copy link
Member

Availability: weekdays 3 - 7pm
ETA: Sep 18 7pm

@mmcclanahan mmcclanahan self-requested a review September 18, 2024 03:03
@mmcclanahan
Copy link
Member

mmcclanahan commented Sep 18, 2024

Availability: 9am - 1pm
ETA: 9/18 11pm

Copy link
Member

@mmcclanahan mmcclanahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work!

correct:
from/to branch
PR title is clear
What/Why is descriptive
Changes made match required changes from issue
No physical changes to website

Good work!

Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great--looks correct now, without that extraneous comment. Approved!

Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @izma-mujeeb,

Great job on the issue! You've done all the standard items such as:

  • good branch name
  • descriptive PR title
  • correct lines of code changed

Specifically, you did an excellent job with the PR comment by providing all the necessary details.

In the spirit of continuous improvement, here are two opinions and nitpicks:

  1. Similar to how you used quotes "New Issue Approval" you could use them for "ready for dev lead" or even use backticks so that it looks like this: ready for dev lead. Again this is just an opinion and a very minor improvement.
  2. I think the title is descriptive but not concise or precise; though, it certainly gets the job done. I used an LLM to brainstorm a bit and came up with "Modify Issue Trigger Workflow: Change label for multiple issue self-assignment". Again just an opinion, your title does the job.

@t-will-gillis t-will-gillis merged commit d35bce8 into hackforla:gh-pages Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Change the label that is added when dev attempts to open multiple issues
5 participants