Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Handle for Moji Jimoh #7445

Merged

Conversation

terrencejihoonjung
Copy link
Member

Fixes #7336

What changes did you make?

  • Created a single variable github-handle to hold the github handle for Moji Jimoh

Why did you make the changes (we will use this info to test)?

  • github-handle will replace the github and picture variables, reducing redundancy in the project file

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No Visual Changes Made.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b terrencejihoonjung-add-github-handle-7336 gh-pages
git pull https://github.com/terrencejihoonjung/website.git add-github-handle-7336

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 13, 2024
@codyyjxn codyyjxn self-requested a review September 13, 2024 19:43
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrencejihoonjung Well Done! Branch is good and the title is concise.

@FamousHero FamousHero self-requested a review September 13, 2024 23:59
Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @terrencejihoonjung, thanks for taking on this issue!

  • Branch name looks good
  • Link to related issue is good
  • Description and reason for the change look good

No extra changes are necessary. Keep it up!

@t-will-gillis t-will-gillis merged commit 640b0ac into hackforla:gh-pages Sep 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Moji Jimoh in youthjusticenav.md
4 participants