-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added github-handle to Kristelle Gumaru #7436
added github-handle to Kristelle Gumaru #7436
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@purna-madala Thank you for taking on your first issue. The branch name looks good. The change looks good as well. The title is concise and clean.
Things that you need to change/check is:
-
You need to check the "Checks section" and see why its not passing the "checked for link issue."
-
You need to change the
Why did you make the changes (we will use this info to test)?
you need to be specific on why you needed to make the change. The labels on the right side already indicate that this is your first issue. -
Here is a reference on an issue if you are having any problems. Add github-handle for Eli Marietta in design-systems.md #7288
-
You also need to answer on the original issue.
"Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)"
ETA: Friday, September 13, 2024 |
Hi @codyyjxn I made the changes, could you review this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@purna-madala Great job on your Good First Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file _projects/home-unite-us.md was edited
- No extra edits were made
- Spaces were used instead of tabs for indenting
- Appearance of the website is unchanged (Chrome and Firefox)
👍 Approved!
Fixes #7180
What changes did you make?
_projects/home-unite-us.md
fileWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)