Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github-handle to Kristelle Gumaru #7436

Conversation

purna-madala
Copy link
Member

@purna-madala purna-madala commented Sep 10, 2024

Fixes #7180

What changes did you make?

  • added github-handle to Kristelle Gumaru in _projects/home-unite-us.md file

Why did you make the changes (we will use this info to test)?

  • change made to streamline the project file by introducing a 'github-handle' key, which replaces the need for separate 'github' and 'picture' entries

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b purna-madala-add-github-handle-kristelle-7180 gh-pages
git pull https://github.com/purna-madala/website.git add-github-handle-kristelle-7180

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 10, 2024
@codyyjxn codyyjxn self-requested a review September 11, 2024 00:36
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purna-madala Thank you for taking on your first issue. The branch name looks good. The change looks good as well. The title is concise and clean.

Things that you need to change/check is:

  • You need to check the "Checks section" and see why its not passing the "checked for link issue."

  • You need to change the Why did you make the changes (we will use this info to test)?
    you need to be specific on why you needed to make the change. The labels on the right side already indicate that this is your first issue.

  • Here is a reference on an issue if you are having any problems. Add github-handle for Eli Marietta in design-systems.md #7288

  • You also need to answer on the original issue.
    "Do let fellow developers know about your:-
    i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
    ii. ETA: (When do you expect this issue to be completed?)"

@DrAcula27
Copy link
Member

ETA: Friday, September 13, 2024
Availability: weekdays after 2pm Pacific Time

@purna-madala
Copy link
Member Author

Hi @codyyjxn I made the changes, could you review this again?

Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purna-madala Great job on your Good First Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file _projects/home-unite-us.md was edited
  • No extra edits were made
  • Spaces were used instead of tabs for indenting
  • Appearance of the website is unchanged (Chrome and Firefox)
    👍 Approved!

@t-will-gillis t-will-gillis merged commit e1ea7d2 into hackforla:gh-pages Sep 15, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Kristelle Gumaru in home-unite-us.md
4 participants