Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle for Michael Morgan in design-systems.md #7291 #7428

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jmarinit
Copy link
Member

@jmarinit jmarinit commented Sep 10, 2024

Fixes #7291

What changes did you make?

  • Added "github-handle" under "-name: Michael Morgan"

Why did you make the changes (we will use this info to test)?

  • We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jmarinit-add-github-handle-7291 gh-pages
git pull https://github.com/jmarinit/website.git add-github-handle-7291

@codyyjxn codyyjxn self-requested a review September 11, 2024 00:32
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarinit Thank you for taking this issue.

Things you need to change:

  • Why did you make the changes (we will use this info to test)? You need to explain why the change was needed. Please read the original issue.
  • On the title you need to assign the correct issue you fixed. The issue don't match the branch name.
  • You also need to check why you are getting these unchecked
    "Pull Request Trigger / Check-For-Linked-Issue (pull_request)
    Details
    @github-actions
    Set PR Labels / generate-labels-artifact (pull_request) F

@Thinking-Panda
Copy link
Member

@jmarinit - please edit the PR description to properly link to the issue you worked on. Add a # to the front of the issue number.

@ramitaarora
Copy link
Member

Availability: Weekday mornings
EoD: Thurs Sept 12

@t-will-gillis
Copy link
Member

t-will-gillis commented Sep 12, 2024

Hi @jmarinit Just to clarify, the top of the PR template includes the words:

Fixes #replace_this_text_with_the_issue_number

The word "Fixes" is required- this is the reason that the two checks "Set PR Labels" and "Pull Request Trigger" are failing. Please edit your description to:

Fixes #7291

Thank you

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jmarinit-add-github-handle-7291 gh-pages
git pull https://github.com/jmarinit/website.git add-github-handle-7291

Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  • You made a pull request from the correct branch
  • You used spaces, not tabs
  • The correct changes are showing up in your branch

All it seems you need to do is add "Fixes" to the beginning of your pull request, and then I can approve.

Good work, and thank you for your contribution!

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 13, 2024
@jmarinit jmarinit self-assigned this Sep 13, 2024
@jmarinit jmarinit changed the title Added github-handle for Michael Morgan. Add github-handle for Michael Morgan in design-systems.md #7291 Sep 13, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jmarinit-add-github-handle-7291 gh-pages
git pull https://github.com/jmarinit/website.git add-github-handle-7291

@jmarinit
Copy link
Member Author

Looks good!

  • You made a pull request from the correct branch
  • You used spaces, not tabs
  • The correct changes are showing up in your branch

All it seems you need to do is add "Fixes" to the beginning of your pull request, and then I can approve.

Good work, and thank you for your contribution!

Thank you! I made the changes. Is that good now because it's still showing that it's failing the checks.

@codyyjxn
Copy link
Member

Nice you need to request another review on the reviewers tab.

@daras-cu
Copy link
Member

@jmarinit well done with this issue! Just a reminder, you do not need to assign yourself to pull requests when you open them, only the original issue.

@daras-cu daras-cu merged commit 62a4e78 into hackforla:gh-pages Sep 16, 2024
8 of 16 checks passed
@jmarinit jmarinit deleted the add-github-handle-7291 branch December 4, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Michael Morgan in design-systems.md
6 participants