-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github-handle for Michael Morgan in design-systems.md #7291 #7428
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmarinit Thank you for taking this issue.
Things you need to change:
-
Why did you make the changes (we will use this info to test)?
You need to explain why the change was needed. Please read the original issue. - On the title you need to assign the correct issue you fixed. The issue don't match the branch name.
- You also need to check why you are getting these unchecked
"Pull Request Trigger / Check-For-Linked-Issue (pull_request)
Details
@github-actions
Set PR Labels / generate-labels-artifact (pull_request) F
@jmarinit - please edit the PR description to properly link to the issue you worked on. Add a # to the front of the issue number. |
Availability: Weekday mornings |
Hi @jmarinit Just to clarify, the top of the PR template includes the words:
The word "Fixes" is required- this is the reason that the two checks "Set PR Labels" and "Pull Request Trigger" are failing. Please edit your description to:
Thank you |
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- You made a pull request from the correct branch
- You used spaces, not tabs
- The correct changes are showing up in your branch
All it seems you need to do is add "Fixes" to the beginning of your pull request, and then I can approve.
Good work, and thank you for your contribution!
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Thank you! I made the changes. Is that good now because it's still showing that it's failing the checks. |
Nice you need to request another review on the reviewers tab. |
@jmarinit well done with this issue! Just a reminder, you do not need to assign yourself to pull requests when you open them, only the original issue. |
Fixes #7291
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website.