Implemented check for changes in Wins-form (Responses) spreadsheet within Wins Data automation #7409
Conversation
…th `iancooperman`
…ata in respository
…te that accidentally committed changes to appsscript.json This reverts commit 1b474c1.
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: front end
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Proposed changes to Wins Form Admin Guide: https://docs.google.com/document/d/1UTv4msXoThx7AwX7g2c8WgBLnwIJeRkaHePvbvI_3sg/edit?usp=sharing |
There was a problem hiding this comment.
Thank you @iancooperman for your work on this complex issue. On the first line of the PR, the issue number (after "Fixes") is incorrect, Please correct that so the PR will be linked correctly to the issue. Thank you.
There was a problem hiding this comment.
@iancooperman Thank you for taking on this issue. The branch name looks good only thing is that I am confused which issue you fixed please correct that if possible. Other than that everything seems to be concise.
github-actions
bot
added
Complexity: Large
size: 2pt
|
@codyyjxn There was a small typo in the linked issue number. Thanks for catching that. Let me know if anything else needs to be done. |
There was a problem hiding this comment.
Hi @iancooperman I'm still testing but I need to ask you to update line 62
There was a problem hiding this comment.
Hi @iancooperman so far the code looks great but
commit 003c436 includes changes to google-apps-scripts/gh-requests/Code.js, which we do not want included in the git repository.
| console.log("Entry difference detected. Updating wins file..."); | ||
| const writeResponse = ghrequests.updateWinsFile(keyValueFile, encodedKeyValueData, keyValueSha); | ||
| if (writeResponse === false) { | ||
| console.log('Ending script...') |
There was a problem hiding this comment.
Please make the console log output message more descriptive
There was a problem hiding this comment.
@roslynwythe Just to confirm, you're saying to remove the changes to appscript.json, right? Your initial comment says Code.js but the commit you linked is to appscript.json.
There was a problem hiding this comment.
@roslynwythe Just to confirm, you're saying to remove the changes to
appscript.json, right? Your initial comment saysCode.jsbut the commit you linked is toappscript.json.
I have assumed this is the case and reverted commit 003c436.
This reverts commit 003c436.
|
@roslynwythe I would appreciate your rereview. |
|
Hey @roslynwythe Do you have any additional comments on this PR? Please let us know-thanks! |
There was a problem hiding this comment.
Great job @iancooperman on this issue which involved an extensive setup and analysis to determine the best strategy to detect changes in the wins data
- Code changes are clean and correct
- PR is well-formed and descriptive
- Changes have been tested in a test repository
To review this PR, I created a test environment in HfLA website Admin/HfLA website Admin/testing_PR_7409 and tested the PR against the production repository, in order to confirm that _wins-data.json is pushed to elizabethonest/website only when there are changes compared to the current contents of that repository.
Your work completing this issue will help us be more efficient in managing wins data updates. Thank you!
Fixes #4154
What changes did you make?
_wins-data.jsonto that of Wins-form (Responses) to see if any changes have been made (e.g. new win, hiding of win, etc.)Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)