-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github-handle to Zeynep Aslan in _projects/design-systems.md #7376
Add github-handle to Zeynep Aslan in _projects/design-systems.md #7376
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: by e.o.d 3-Sep-24 |
Review ETA: EOD Sep 4, 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FamousHero , in your writeup, please include a Screenshots of the changes made
section and mention No visual changes were made to the website
under it. Ping me once you're done, and I'll go ahead and approve the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! @FamousHero
- The branches from and to are setup correctly
- Link to the issue is included
- There is a clean description of what was done and why
- No visual changes were made to the website
Thanks for woking on this issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FamousHero,
What went well:
- PR title is descriptive.
- Branch is named correctly.
- Related issue is linked.
- Why and What sections are answered well.
- Correct line of code is changed.
Great job on this, everything looks good. Keep up the good work!
Fixes #7286
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)