Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle to Zeynep Aslan in _projects/design-systems.md #7376

Conversation

FamousHero
Copy link
Member

@FamousHero FamousHero commented Sep 1, 2024

Fixes #7286

What changes did you make?

  • Add "github-handle:" for Zeynep Aslan in design-systems.md

Why did you make the changes (we will use this info to test)?

  • Future plans to remove github & picture fields to reduce redundancy

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes were made to the website

Copy link

github-actions bot commented Sep 1, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b FamousHero-zeynep-aslan-github-handle-7286 gh-pages
git pull https://github.com/FamousHero/H4LAwebsite.git zeynep-aslan-github-handle-7286

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 2, 2024
@buneeIsSlo buneeIsSlo self-requested a review September 2, 2024 12:33
@buneeIsSlo
Copy link
Member

Review ETA: by e.o.d 3-Sep-24
Availability: 7AM to 10AM weekdays

@8alpreet 8alpreet self-requested a review September 3, 2024 15:32
@8alpreet
Copy link
Member

8alpreet commented Sep 3, 2024

Review ETA: EOD Sep 4, 2024
Availability: 3pm to 7pm weekdays

Copy link
Member

@buneeIsSlo buneeIsSlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FamousHero , in your writeup, please include a Screenshots of the changes made section and mention No visual changes were made to the website under it. Ping me once you're done, and I'll go ahead and approve the changes.

Copy link
Member

@buneeIsSlo buneeIsSlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! @FamousHero

  • The branches from and to are setup correctly
  • Link to the issue is included
  • There is a clean description of what was done and why
  • No visual changes were made to the website

Thanks for woking on this issue!

Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FamousHero,

What went well:

  • PR title is descriptive.
  • Branch is named correctly.
  • Related issue is linked.
  • Why and What sections are answered well.
  • Correct line of code is changed.

Great job on this, everything looks good. Keep up the good work!

@Thinking-Panda Thinking-Panda merged commit 3b4123d into hackforla:gh-pages Sep 4, 2024
10 of 12 checks passed
@FamousHero FamousHero deleted the zeynep-aslan-github-handle-7286 branch September 6, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Zeynep Aslan in design-systems.md
4 participants