Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle for Erik Guntner in home-unite-us.md #7370

Conversation

ihop-56
Copy link
Member

@ihop-56 ihop-56 commented Aug 30, 2024

Fixes #7179

What changes did you make?

  • Added github-handle: field under name: Erik Guntner in the _projects/home-unite-us.md file.

Why did you make the changes (we will use this info to test)?

  • The change was made to prepare the project file for future enhancements by standardizing the GitHub handle field.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ihop-56-add-erik-guntner-github-handle-7179 gh-pages
git pull https://github.com/ihop-56/website.git add-erik-guntner-github-handle-7179

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 30, 2024
@vorleakyek vorleakyek self-requested a review August 31, 2024 04:01
Copy link
Member

@vorleakyek vorleakyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Thanks for contributing.

@8alpreet
Copy link
Member

8alpreet commented Sep 3, 2024

Review ETA: EOD Sep 4, 2024
Availability: 3pm to 7pm weekdays

Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihop-56,

What went well:

  • PR title is descriptive and concise.
  • Branch is named correctly.
  • Correct lines of code were changed.
  • All sections of PR comment are well done.
  • Issue is linked.

Wow, you did an amazing job on this one. Great job on learning from your last GFI. Keep up the good work!

@k-cardon k-cardon self-requested a review September 4, 2024 20:54
Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good--branched correctly, added the code w/ spaces instead of tab, and I confirmed the site is unchanged visually. Good work!

@Thinking-Panda Thinking-Panda merged commit bef9513 into hackforla:gh-pages Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Erik Guntner in home-unite-us.md
5 participants