Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Handle for Yingjie Ou #7241 #7368

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add Github Handle for Yingjie Ou #7241 #7368

merged 1 commit into from
Sep 9, 2024

Conversation

mimiwrp
Copy link
Member

@mimiwrp mimiwrp commented Aug 30, 2024 •
edited
Loading

Fixes #7241

What changes did you make?

  • Add "github-handle:" to Yingjie Ou in the file _projects/tech-work-experience.md

Why did you make these changes

  • Adding "github-handle" to store github handle for contributor

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b mimiwrp-add-github-handle-7241 gh-pages
git pull https://github.com/mimiwrp/HfLA-website.git add-github-handle-7241

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) 2 weeks inactive size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 30, 2024
@vorleakyek vorleakyek self-requested a review August 31, 2024 03:36
vorleakyek
vorleakyek approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@vorleakyek vorleakyek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! Approved!

Two small comments:

  1. Please edit your comment and add the "Why did you make the changes (we will use this info to test)?" in the PR comment as suggested in 3.1 How to make a pull request.
  2. Something to consider in the future: maybe include the person's name in the branch name for clarity

Thanks for contributing!

@vorleakyek vorleakyek mentioned this pull request Aug 31, 2024
Open
daras-cu
daras-cu requested changes Sep 1, 2024
View reviewed changes
Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mimiwrp, thanks for working on this issue. Everything looks good except as mentioned you are missing the "Why did you make these changes" section in your PR.

  • Branches are set up correctly (I agree your branch names could be a little more specific in the future)
  • Original issue is linked in the PR
  • Changes to the file were made according to original issue
  • Testing confirms the website is not changed visually

Once you add the missing section to your PR it will be ready to approve. Nice work!

@Thinking-Panda
Copy link
Member

@mimiwrp - Please make the requested changes and request a re-review.
screenshotPR

@mimiwrp
Copy link
Member Author

mimiwrp commented Sep 5, 2024

Why did you make these changes

  • Adding "github-handle" to store github handle for contributor

@mimiwrp mimiwrp requested a review from daras-cu September 5, 2024 06:46
@codyyjxn codyyjxn self-requested a review September 5, 2024 16:04
codyyjxn
codyyjxn requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mimiwrp
Thank you for taking on this issue. Everything looks good you are missing the: Why did you make the changes (we will use this info to test)?
This needs to be added in the comment underneath the
What changes did you make?

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Sep 5, 2024
@mimiwrp mimiwrp requested a review from codyyjxn September 5, 2024 18:10
@mimiwrp
Copy link
Member Author

mimiwrp commented Sep 5, 2024

@vorleakyek @daras-cu @Thinking-Panda @codyyjxn Thank you so much for taking your time to review my pull request. I just edit the comment and I'm so sorry for the delay.

daras-cu
daras-cu approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that section @mimiwrp, everything looks good!

@t-will-gillis t-will-gillis merged commit 7d72ccc into hackforla:gh-pages Sep 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyyjxn codyyjxn codyyjxn approved these changes

@daras-cu daras-cu daras-cu approved these changes

@vorleakyek vorleakyek vorleakyek approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add github-handle for Yingjie Ou in tech-work-experience.md
6 participants
@mimiwrp @Thinking-Panda @vorleakyek @daras-cu @codyyjxn @t-will-gillis