Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle for Ebi Imafidon in tdm-calculator.md 7173 #7307

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

kgold2018
Copy link
Member

Fixes #7173

What changes did you make?

  • Add github-handle for Ebi Imafidon

Why did you make the changes (we will use this info to test)?

  • To hold the github handle for each member of the leadership team

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b kgold2018-add-github-handle-7173 gh-pages
git pull https://github.com/kgold2018/website.git add-github-handle-7173

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 17, 2024
@iancooperman iancooperman self-requested a review August 17, 2024 17:50
@iancooperman
Copy link
Member

Review ETA: EoD

Copy link
Member

@iancooperman iancooperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but please check off all the relevant action items on the original issue.

@kgold2018
Copy link
Member Author

@iancooperman I reviewed an original issue and addressed all relevant action items you requested. Thank you!

@t-will-gillis t-will-gillis requested a review from ihop-56 August 18, 2024 17:09
Copy link
Member

@iancooperman iancooperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgold2018 Thank you.

@LRenDO
Copy link
Member

LRenDO commented Aug 22, 2024

Hi @ihop-56! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability. If for some reason you find that you're unable to review the request, please remove yourself as a reviewer. Thanks!

@t-will-gillis t-will-gillis requested review from t-will-gillis and removed request for ihop-56 August 22, 2024 17:28
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kgold2018 - Everything looks good!

  • branches are correct
  • pr is linked to orig issue
  • description of what was changed and why is concise
  • code changes are clean
    Thanks for working on this!

@t-will-gillis t-will-gillis merged commit f4f560a into hackforla:gh-pages Aug 22, 2024
6 checks passed
Copy link
Member

@ihop-56 ihop-56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kgold2018, I reviewed the changes, and everything looks great. The github-handle was correctly added for Ebi Imafidon as per the issue instructions. There are no visual changes to the website, and the code is clean and well-formatted. Nice job!

@ihop-56 ihop-56 requested review from ihop-56 and removed request for ihop-56 August 23, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Ebi Imafidon in tdm-calculator.md
6 participants