Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github handle for Angela Darosh on tech-work-experience.md #7302

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

bexux
Copy link
Member

@bexux bexux commented Aug 16, 2024

Fixes #7247

What changes did you make?

  • Using spaces, added the variable github-handle under Angela Darosh

Why did you make the changes (we will use this info to test)?

  • We need to create a single variable github-handle to hold the github handle for each member of the leadership team.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b bexux-7247-add-github-handle gh-pages
git pull https://github.com/bexux/website.git 7247-add-github-handle

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 16, 2024
@mmcclanahan mmcclanahan self-assigned this Aug 18, 2024
@mmcclanahan
Copy link
Member

Review ETA: 10 PM 8/17/24
Availability: 8am-pm Sunday, available throughout work week

Copy link
Member

@mmcclanahan mmcclanahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Checklist:
To and from branches are correct
Link to the issue included
Clear and concise description of what was done and why
No visual changes made

Nice Work!

@jennisung
Copy link
Member

jennisung commented Aug 18, 2024

Review ETA: 10 PM 8/19/24
Availability: Friday - Monday 6 pm to 12pm EST

Copy link
Member

@jennisung jennisung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks good. I see the added "github handle" under the intended user. The branches are correct.The documentation is also written and formatted correctly. Great job.

@roslynwythe roslynwythe merged commit c7245c4 into hackforla:gh-pages Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Angela Darosh in tech-work-experience.md
4 participants