Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Github with GitHub in pages/getting-started.html #7230

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

Kle012
Copy link
Member

@Kle012 Kle012 commented Aug 7, 2024

Fixes #7118

What changes did you make?

  • Change:
    <li class="g-s-list">Receive access to the Google Drive and Github repository by sending a Slack message of your Github username and Gmail address to a CoP lead. <img class="info-icon" src="assets/images/getting-started/information.png" alt="">
  • To:
    <li class="g-s-list">Receive access to the Google Drive and GitHub repository by sending a Slack message of your GitHub username and Gmail address to a CoP lead. <img class="info-icon" src="assets/images/getting-started/information.png" alt="">

Why did you make the changes (we will use this info to test)?

  • Make sure company name GitHub displays with proper capitalization throughout the website

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

Connected files

  • The getting-started.html is used to populate the HackforLA Getting Started page
  • The visual change can be observed in Step 2: Join Your Community of Practice (as shown in pictures attached above)

Test

Copy link

github-actions bot commented Aug 7, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Kle012-replace-Github-7118 gh-pages
git pull https://github.com/Kle012/website.git replace-Github-7118

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 1pt Can be done in 4-6 hours labels Aug 7, 2024
@Anahisv23 Anahisv23 requested review from Anahisv23 and removed request for Anahisv23 August 7, 2024 23:03
Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kle012, thanks for working on this issue! Everything looks good on my end. Here's what you did well.

What went well

  • Into and from branch are correct
  • Linked issue links to the correct issue
  • Appropriate lines of code were changed to change Github to GitHub
  • All the links in that section redirect correctly
  • The localhost getting started page has the correct changes
  • PR clearly describes what you changed and why you changed it as well as the connected files and how to test

Overall great work!

@t-will-gillis t-will-gillis self-requested a review August 10, 2024 19:46
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Kle012 everything looks great-

  • branches are good
  • linked back to original issue
  • the description is fine- you could also say this more concisely by stating that you corrected the capitalization of "GitHub" in pages/getting-started.html
  • the before and after screenshots are appropriate
  • the code changes are clean

Thanks for working on this!

@t-will-gillis t-will-gillis merged commit 59e79d9 into hackforla:gh-pages Aug 10, 2024
6 checks passed
del9ra pushed a commit to del9ra/website that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in pages/getting-started.html
3 participants