-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GitHub with GitHub in ui-ux.yml #7150
Replace GitHub with GitHub in ui-ux.yml #7150
Conversation
…replace-Github-with-GitHub-7113
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD 7/27/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the ui-ux.yml file and made visual confirmation that the name attribute for the GitHub link was changed to the correct text of "GitHub", with no visual changes to the website. Good job!
Hi @daras-cu, @buneeIsSlo, @Kle012, and @taylorbeee Just a friendly reminder- Since each of your open PRs are similar, you can help the review process move along by reviewing each other’s PRs. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @taylorbeee, when I try to run the website to test I get an error connected to the ui-ux.yml
file, it looks like you also changed the indent of line 49 when editing. The error:
… into replace-Github-with-GitHub-7113
Thank you for this heads up @daras-cu !! I believe I fixed the issue. |
Hey @taylorbeee please don't forget to "Re-request review" from 'daras-cu' by selecting the chasing arrows next to their name, eg: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taylorbeee looks great, I'm no longer getting the error and the page is displaying without any visual changes. Everything else looks correct with the pull request, good job.
Fixes #7113
Link to test procedure comment: #7113 (comment)
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)