Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GitHub with GitHub in ui-ux.yml #7150

Merged

Conversation

taylorbeee
Copy link
Member

Fixes #7113

  • The elements edited in this pull request are from the data stored in .yml file that is referenced when the page: www.hackforla.org/communities-of-practice is launched. This page then fetches each .yml and loads them as separate cards indicating the different communities and leaders' contact information.

Link to test procedure comment: #7113 (comment)

What changes did you make?

  • Change links.name from Github to GitHub

Why did you make the changes (we will use this info to test)?

  • This change was made to have all the code spell the brand 'GitHub's name correctly and be uniform throughout the project.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • N/A

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b taylorbeee-replace-Github-with-GitHub-7113 gh-pages
git pull https://github.com/taylorbeee/website.git replace-Github-with-GitHub-7113

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 1pt Can be done in 4-6 hours labels Jul 27, 2024
@aadilahmed aadilahmed self-requested a review July 28, 2024 01:52
@aadilahmed
Copy link
Member

Review ETA: EOD 7/27/24
Availability: 9-5 PM Monday - Friday

aadilahmed
aadilahmed previously approved these changes Jul 28, 2024
Copy link
Member

@aadilahmed aadilahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the ui-ux.yml file and made visual confirmation that the name attribute for the GitHub link was changed to the correct text of "GitHub", with no visual changes to the website. Good job!

@t-will-gillis
Copy link
Member

Hi @daras-cu, @buneeIsSlo, @Kle012, and @taylorbeee Just a friendly reminder- Since each of your open PRs are similar, you can help the review process move along by reviewing each other’s PRs. Thanks!

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @taylorbeee, when I try to run the website to test I get an error connected to the ui-ux.yml file, it looks like you also changed the indent of line 49 when editing. The error:

Screenshot 2024-07-29 153544

@taylorbeee
Copy link
Member Author

Hi @taylorbeee, when I try to run the website to test I get an error connected to the ui-ux.yml file, it looks like you also changed the indent of line 49 when editing. The error:

Screenshot 2024-07-29 153544

Thank you for this heads up @daras-cu !! I believe I fixed the issue.

@t-will-gillis
Copy link
Member

Hey @taylorbeee please don't forget to "Re-request review" from 'daras-cu' by selecting the chasing arrows next to their name, eg:

Screenshot 2024-07-31 143413

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taylorbeee looks great, I'm no longer getting the error and the page is displaying without any visual changes. Everything else looks correct with the pull request, good job.

@t-will-gillis t-will-gillis merged commit c6be9f5 into hackforla:gh-pages Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in _data/internal/communities/ui-ux.yml
5 participants