Lack of preloaded data made meeting times heading disappear #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preloading on our project pages
|
Does this need to be fixed on the vrms team? |
|
The data we are getting from the VRMS team in the AJAX request is correct - and the data we retrieve nightly is correct. However, there was a name mismatch between the file the meeting pages were using and the file we were storing each night via GitHub Actions. This PR fixes the templates to use the file that gets updated nightly. I did not figure out why not having any meetings on the first load makes the meetings header not appear when the AJAX data brings in new meetings. We might want to open a separate issue to address that. |
|
No problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue opened on the VRMS issue queue hackforla/VRMS#232 (comment)