Replace Github with GitHub in project-managment.yml #7136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: front end
|
Not entirely sure if I got everything right. If there's anything wrong, please let me know :) |
|
Hi @daras-cu, @buneeIsSlo, @Kle012, and @taylorbeee Just a friendly reminder- Since each of your open PRs are similar, you can help the review process move along by reviewing each other’s PRs. Thanks! |
daras-cu
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Hi @buneeIsSlo, everything looks good to me with your changes:
- Branches are set correctly
- Issue is linked to PR
- Explanation of changes and testing procedure for reviewers
- No visual changes to the website when testing
Great job!
|
Review ETA: EOD 7/29/2024 |
Kle012
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Hi @buneeIsSlo, everything looks great:
- Branching looks good
- Relevant issue is linked
- The spelling of GitHub is correct
- No visual changes to the website
Thank you for contributing! :)
buneeIsSlo
deleted the
fix-github-spelling-data-project-management-7117
branch
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7117
What changes did you make?
- name: Githubwith- name: GitHubin_data/internal/communities/project-management.ymlWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes to the Website
Test
- name: GitHubis not directly referenced in any files, there should be no visual changes.Project/Product Managementcard on the local website at http://localhost:4000/communities-of-practice to the live website at http://www.hackforla.org/communities-of-practice and verify that there are no differences.