Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Github' with 'GitHub' in engineering.yml #7131

Merged

Conversation

daras-cu
Copy link
Member

Fixes #7115

What changes did you make?

  • In _data/internal/communities/engineering.yml, replaced - name: Github with - name: GitHub on line 44

Why did you make the changes (we will use this info to test)?

  • Make sure company name GitHub displays with proper capitalization throughout the website

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

Testing

The engineering.yml file is used to populate the Engineering card template on the Communities of Practice page (\pages\communities-of-practice.html). However, the template never references the - name: GitHub element that has been edited. Therefore, there should be no visual changes to the page.

To test:

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b daras-cu-replace-github-engineering.yml-7115 gh-pages
git pull https://github.com/daras-cu/website.git replace-github-engineering.yml-7115

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 1pt Can be done in 4-6 hours labels Jul 21, 2024
@ramitaarora ramitaarora self-requested a review July 22, 2024 17:00
@ramitaarora
Copy link
Member

Availability: Weekday mornings
ETA: July 23rd EoD

Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

  • You linked the issue correctly
  • You made a pull request from your branch and merging into gh-pages
  • The spelling of GitHub is correct
  • No visual changes on website

Great work! Thank you for contributing :)

@t-will-gillis
Copy link
Member

Hi @daras-cu, @buneeIsSlo, @Kle012, and @taylorbeee Just a friendly reminder- Since each of your open PRs are similar, you can help the review process move along by reviewing each other’s PRs. Thanks!

@Kle012 Kle012 self-requested a review July 30, 2024 01:35
Copy link
Member

@buneeIsSlo buneeIsSlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daras-cu Great work!

  • The branches from and to are setup correctly
  • Link to the issue is included
  • There is a clear and concise description of what was done and why
  • No visual changes were made to the website

Thanks for working on this issue and for creating such a comprehensive PR :)

@Kle012 Kle012 marked this pull request as draft July 31, 2024 00:19
@Kle012 Kle012 marked this pull request as ready for review July 31, 2024 00:20
@Kle012 Kle012 removed their request for review July 31, 2024 00:20
@t-will-gillis t-will-gillis self-requested a review July 31, 2024 21:16
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daras-cu Good job- branches, code links, description, and code edits all are good. I checked in Docker and I agree that this does not appear to affect the website, and the link works as normal.

The issue did not specifically reference line 44, however reading back to the initiating issue 6161 this is the intended change- and not for example the references to github on lines 26, 32, 38 and sim.

Great job and thanks for working on this!

@t-will-gillis t-will-gillis merged commit 4a1f9a1 into hackforla:gh-pages Jul 31, 2024
6 checks passed
@daras-cu daras-cu deleted the replace-github-engineering.yml-7115 branch August 5, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in _data/internal/communities/engineering.yml
4 participants