-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 'Github' with 'GitHub' in engineering.yml #7131
Replace 'Github' with 'GitHub' in engineering.yml #7131
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: Weekday mornings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
- You linked the issue correctly
- You made a pull request from your branch and merging into gh-pages
- The spelling of GitHub is correct
- No visual changes on website
Great work! Thank you for contributing :)
Hi @daras-cu, @buneeIsSlo, @Kle012, and @taylorbeee Just a friendly reminder- Since each of your open PRs are similar, you can help the review process move along by reviewing each other’s PRs. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @daras-cu Great work!
- The branches from and to are setup correctly
- Link to the issue is included
- There is a clear and concise description of what was done and why
- No visual changes were made to the website
Thanks for working on this issue and for creating such a comprehensive PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @daras-cu Good job- branches, code links, description, and code edits all are good. I checked in Docker and I agree that this does not appear to affect the website, and the link works as normal.
The issue did not specifically reference line 44, however reading back to the initiating issue 6161 this is the intended change- and not for example the references to github
on lines 26, 32, 38 and sim.
Great job and thanks for working on this!
Fixes #7115
What changes did you make?
_data/internal/communities/engineering.yml
, replaced- name: Github
with- name: GitHub
on line 44Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes
Testing
The engineering.yml file is used to populate the Engineering card template on the Communities of Practice page (\pages\communities-of-practice.html). However, the template never references the
- name: GitHub
element that has been edited. Therefore, there should be no visual changes to the page.To test:
Follow Step 3 in How to Review Pull Requests to run the updated website
Compare the Communities of Practice page "http://localhost:4000/communities-of-practice" to the live page on the HfLA website "http://www.hackforla.org/communities-of-practice"
Check the Engineering card and verify there are no visual differences
View the page source for both versions and verify that the contents of the div containing the Slack and GitHub link buttons in the Engineering card are the same, specifically the titles of the button elements and the link addresses