Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Capitalization of "Slack" in CONTRIBUTING.MD #7017

Merged

Conversation

dcotelessa
Copy link
Member

Fixes #6918

What changes did you make?

  • capitalize slack to Slack on line 11 of CONTRIBUTING.md

Why did you make the changes (we will use this info to test)?

No visuals on websites changed.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/dcotelessa/website/blob/fix-capitalization-slack-6918/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Jun 18, 2024
@A-Wu5 A-Wu5 self-requested a review June 18, 2024 23:58
@A-Wu5
Copy link
Member

A-Wu5 commented Jun 18, 2024

Availability: Tues/Wed 5-7pm
ETA: EOD

Copy link
Member

@A-Wu5 A-Wu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @dcotelessa on this issue! Everything seems to be linked correctly and the change looks good to me.

@Anahisv23 Anahisv23 self-requested a review June 19, 2024 21:49
@Anahisv23
Copy link
Member

Availability: M - F 11am - 5pm
ETA: EOD

Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dcotelessa, thanks for working on this issue. Everything looks good. The only constructive feedback I have is to make sure to be more descriptive on your PR on why you made the changes you made. Other than that it looks great!

Here's what you did well

  • PR links to correct issue
  • into and from branch look good
  • Changed appropriate lines of code and did not modify the word "slack" in the URLs
  • Changed the lowercase "s" to and uppercase "S" in the word "Slack"

@jphamtv jphamtv merged commit 7003069 into hackforla:gh-pages Jun 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Capitalization of "Slack" in CONTRIBUTING.MD
4 participants