Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project profile: expunge assist(remove Curtis add Maria) #7012

Conversation

buneeIsSlo
Copy link
Member

Fixes #6866

What changes did you make?

  • Removed Curts Barbers' profile and added Maria Weissmans' profile in Expunge Assist file.

Why did you make the changes?

  • To keep project information up to date so that visitors to the website can find accurate information.

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied

Before

Visuals after changes are applied

After

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b buneeIsSlo-expunge-assist-remove-curtis-add-maria-6866 gh-pages
git pull https://github.com/buneeIsSlo/website.git expunge-assist-remove-curtis-add-maria-6866

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 17, 2024
@buneeIsSlo buneeIsSlo requested a review from t-will-gillis June 17, 2024 11:49
Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @buneeIsSlo, your changes look good and fulfill the issue instructions, good job!

  • Branches are set up correctly
  • PR format is correct with linked issue and before/after screenshots
  • Removed correct profile and added new profile in the right place
  • Changes appear in the browser, rest of page is unaffected

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @buneeIsSlo Great job!

  • branches 'from' and 'to' look good
  • The original issue is linked correctly
  • There is a succinct description of what was done and why
  • Appropriate before and after screenshots are provided to show the changes
  • The code changes are clean, and bonus points for the correct placement of Maria's profile

Great work again, and thanks for working on this issue!

@t-will-gillis t-will-gillis merged commit bdfa4b5 into hackforla:gh-pages Jun 19, 2024
10 checks passed
@buneeIsSlo buneeIsSlo deleted the expunge-assist-remove-curtis-add-maria-6866 branch June 19, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist (Remove Curtis Barber, Add Maria Weissman)
3 participants