Standardize Slack channels using ID and archives: CONTRIBUTING.md Section 1.5 #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
github-actions
bot
added
role: front end
freaky4wrld
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
@dcotelessa thanks for working on the issue
- branches looks good
- link to issue is correct
- changes made are correct and the link provided has the desired changes
PR approved!!
|
Availability: 6/12 5PM - 10PM |
ino-iosdev
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Hi @dcotelessa , It's such a blessing to have you as part of the team here!
- Branch naming was appropriate
- Direction between branches
fromandtoare clear - The changes and why were clear
- PR issue ticket was properly linked
- Changes were only made in section 1.5
- Tested and the change was reflected in https://github.com/dcotelessa/website/blob/slack-channel-contributing-section-1.5-6848/CONTRIBUTING.md
Great job, thank you for contributing!
moazDev1
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Hey @dcotelessa, Great job working in this issue and accomplish the following:
- Using the correct branch
- Making changes as requested in the issue
- Clean and readable code
- Changes appeared on the website without any issues
Keep going!
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6848
What changes did you make?
Why did you make the changes (we will use this info to test)?