Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle for Lex Roman in heart.md #6983

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

daras-cu
Copy link
Member

Fixes #6936

What changes did you make?

  • In heart.md replaced
- name: Lex Roman

with

- name: Lex Roman
  github-handle: 

Why did you make the changes (we will use this info to test)?

  • This change was called for in the issue action items

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b daras-cu-add-gh-Lex-Roman-6936 gh-pages
git pull https://github.com/daras-cu/website.git add-gh-Lex-Roman-6936

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 10, 2024
@partapparam partapparam self-requested a review June 11, 2024 00:57
Copy link
Member

@partapparam partapparam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daras-cu great job!
The branching was done correctly
You linked the issue.
Code changes were made correctly as stated.
I'm able to confirm in docker that the appearance of the project webpage is unchanged.
Great Job!

@Thinking-Panda Thinking-Panda self-requested a review June 11, 2024 18:00
Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daras-cu Thank you for working on this issue. Merge branches are set up correct, code changes are as mentioned in the linked issue and clean. Website also works good on my local machine. Well done!

@Thinking-Panda Thinking-Panda merged commit e971e5b into hackforla:gh-pages Jun 11, 2024
10 checks passed
@daras-cu daras-cu deleted the add-gh-Lex-Roman-6936 branch June 14, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github-handle for Lex Roman in heart.md
4 participants