Update Project page's GitHub icon to icon-github.svg #6973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: front end
ha-bach
changed the title
|
Review ETA: 6/11/24, 11:59pm PST |
|
Review ETA: EOD 6/11/24 |
terrencejihoonjung
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Hi @muninnhugin,
- branches are correctly specified
- title is clear, changes made and why they were made are clearly stated, and visual changes are appropriately shown
- removed
{% include svg/icon-github-color.svg %}and added{% include svg/icon-github.svg %} - deleted icon-github-color.svg file
- added appropriate styling to _project-page.scss and visual changes look consistent
Great job! Thanks for your help!
aadilahmed
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6909
What changes did you make?
_includes/svg/icon-github.svginstead of_includes/svg/icon-github-color.svg_sass/components/_project-page.scssso that the new icon is displayed appropriately_includes/svg/icon-github-color.svgWhy did you make the changes (we will use this info to test)?
_includes/svg/icon-github-color.svgScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied