-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mario Antonini to Merge Team #6924
Add Mario Antonini to Merge Team #6924
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
This ticket is an update of this PR: |
ETA: End of 6/5 |
Review ETA: 06/03/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dcotelessa!
The branching was done correctly, you linked the issue, you gave a description of what you did and why the changes were made, and also provided the appropriate before and after screenshots.
I'm able to verify in docker that the changes appear correctly on the website project page.
Thank you for taking up and completing this issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dcotelessa , It's such a blessing to have you as part of the team here!
- Naming was appropriate
- Direction between branches
from
andto
are clear - The changes and why were clear
- PR issue link was clear
- visual changes to the website look good, screenshots are very helpful
Great job, thank you for contributing!
@robertnjenga for some reason your approval checkmark wasn't showing up. I wonder if it's because you didn't review in the yellow warning pop-up on the top, or can also do it in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR approved in previous comment.
@dcotelessa Thank you for working on this issue. |
Fixes #6864
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied