Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mario Antonini to Merge Team #6924

Conversation

dcotelessa
Copy link
Member

Fixes #6864

What changes did you make?

  • Added Mario Antonini name, github-handle (blank), role, slack link, github link, and picture to the end of the leadership variable
- name: Mario Antonini
  github-handle: 
  role: Merge Team
  links:
    slack: 'https://hackforla.slack.com/team/U06MTPZ67V3'
    github: 'https://github.com/marioantonini'
  picture: https://avatars.githubusercontent.com/marioantonini

Why did you make the changes (we will use this info to test)?

  • Mario Antonini is being added to Merge Team

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

https://github.com/hackforla/website/assets/5404705/5885e29a-29f3-4096-a835-467bf66b0029

Visuals after changes are applied

https://github.com/hackforla/website/assets/5404705/4537a02c-913b-4ac0-9e82-28db8de71c50

Copy link

github-actions bot commented Jun 2, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b dcotelessa-add-mario-antonini-to-merge-team-6864 gh-pages
git pull https://github.com/dcotelessa/website-hackforla.git add-mario-antonini-to-merge-team-6864

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 2, 2024
@dcotelessa
Copy link
Member Author

This ticket is an update of this PR:
#6921
to rename the branch to include the ticket #.

@ino-iosdev ino-iosdev self-requested a review June 2, 2024 07:53
@ino-iosdev
Copy link
Member

ino-iosdev commented Jun 3, 2024

ETA: End of 6/5

@robertnjenga
Copy link
Member

Review ETA: 06/03/2024
Availability: 10am - 2pm

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dcotelessa!
The branching was done correctly, you linked the issue, you gave a description of what you did and why the changes were made, and also provided the appropriate before and after screenshots.
I'm able to verify in docker that the changes appear correctly on the website project page.
Thank you for taking up and completing this issue!

Copy link
Member

@ino-iosdev ino-iosdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dcotelessa , It's such a blessing to have you as part of the team here!
 

  • Naming was appropriate
  • Direction between branches from and to are clear
  • The changes and why were clear
  • PR issue link was clear
  • visual changes to the website look good, screenshots are very helpful
     
    Great job, thank you for contributing!

@ino-iosdev
Copy link
Member

ino-iosdev commented Jun 5, 2024

Hi @dcotelessa! The branching was done correctly, you linked the issue, you gave a description of what you did and why the changes were made, and also provided the appropriate before and after screenshots. I'm able to verify in docker that the changes appear correctly on the website project page. Thank you for taking up and completing this issue!

@robertnjenga for some reason your approval checkmark wasn't showing up.

Screenshot 2024-06-05 at 1 10 55 AM

I wonder if it's because you didn't review in the yellow warning pop-up on the top, or can also do it in the Files changed tab to sync the approval to have the checkmark appear. I'm not sure whether missing this checkmark affects the merging team's progress to move forward.


Screenshot 2024-06-05 at 1 15 27 AM

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved in previous comment.

@Thinking-Panda
Copy link
Member

@dcotelessa Thank you for working on this issue.

@Thinking-Panda Thinking-Panda merged commit 0d0ed2a into hackforla:gh-pages Jun 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Add Mario Antonini to Merge Team
4 participants