Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle for Selena Jiang in ems-triage-tracker.md #6898

Merged

Conversation

dcotelessa
Copy link
Member

@dcotelessa dcotelessa commented May 26, 2024

Fixes #6723

What changes did you make?

  • On _projects/ems-triage-tracker.md,
    • added github-handle: under - name: Selena Jiang

Why did you make the changes (we will use this info to test)?

  • We need to create a single variable github-handle to hold the github handle for Selena Jiang.
  • No visual changes, but handle is now in the yaml.

No visual changes to website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b dcotelessa-github-handle-selena-jiang-6723 gh-pages
git pull https://github.com/dcotelessa/website-hackforla.git github-handle-selena-jiang-6723

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 26, 2024
@gaylem gaylem requested review from jennisung and mrodz May 26, 2024 17:06
Copy link
Member

@mrodz mrodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ETA: 11 AM 5/26/24

This looks great! Besides the formatting issues presented by @t-will-gillis, you followed the items on the checklist and followed the protocol for submitting a PR.

  • Branching done correctly
  • Issue included
  • Used spaces and correctly added the github-handle property
  • Proper naming of the issue

Congrats on the PR! Thank you for the contribution.

@t-will-gillis t-will-gillis self-requested a review May 27, 2024 18:16
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dcotelessa Congrats on your first HfLA PR-

  • Branches 'from' and 'into' are correct
  • Original issue is linked
  • A brief description of what was done and why is provided
  • The code edit is clean

Some notes:

  • Under the 'what change' and 'why', please remove the extra lines
  • Under 'Screenshots of Proposed Changes..." please remove everything and replace with something to the effect of "No visual changes to website"

Thanks for working on this!

@t-will-gillis
Copy link
Member

Hi @mrodz
There is not a specific format that needs to be followed when leaving a PR review, but there are specific items that a good PR review checks for, and it is helpful for everyone when the reviewer leaves specific (and encouraging) reasons for why the PR is being approved or why changes are being requested.

Here is an example of a well-done review: #6887 (review) When we look at this, we can see both that the reviewer has done a thorough job checking the PR, and the reviewee has done their job in creating the PR.

@mrodz
Copy link
Member

mrodz commented May 27, 2024

Hi @mrodz There is not a specific format that needs to be followed when leaving a PR review, but there are specific items that a good PR review checks for, and it is helpful for everyone when the reviewer leaves specific (and encouraging) reasons for why the PR is being approved or why changes are being requested.

Here is an example of a well-done review: #6887 (review) When we look at this, we can see both that the reviewer has done a thorough job checking the PR, and the reviewee has done their job in creating the PR.

Thank you for the help! I am new to reviewing PR's and I appreciate the feedback. I will use your tips for the next PR's I review.

@mrodz mrodz self-requested a review May 28, 2024 01:27
@dcotelessa
Copy link
Member Author

Great feedback. I will keep the format in mind for readability. Thanks!

@t-will-gillis t-will-gillis self-requested a review May 30, 2024 03:15
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dcotelessa - Perfect, thanks for making the edits. Everything looks great!

Copy link
Member

@mrodz mrodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am re-approving this PR as the formatting was fixed. Good work!

@t-will-gillis t-will-gillis merged commit 26fd71d into hackforla:gh-pages May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github-handle for Selena Jiang in ems-triage-tracker.md
3 participants