Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github-handle for Conor McKiernan #6897

Merged

Conversation

terrencejihoonjung
Copy link
Member

Fixes #6722

What changes did you make?

  • created a single variable "github-handle" under "name" variable" for Conor McKiernan

Why did you make the changes (we will use this info to test)?

  • in the future github-handle will replace the github and picture variables, reducing redundancy in the project file

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screenshots of Proposed Changes Of The Website

  • Added variable to ems-triage-tracker.md file. No visual changes to the website.

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 26, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b terrencejihoonjung-add-github-handle-6722 gh-pages
git pull https://github.com/terrencejihoonjung/website.git add-github-handle-6722

@t-will-gillis
Copy link
Member

Hi @dcotelessa
There is not a specific format that needs to be followed when leaving a PR review, but there are specific items that a good PR review checks for, and it is helpful for everyone when the reviewer leaves specific (and encouraging) reasons for why the PR is being approved or why changes are being requested.

Here is an example of a well-done review: #6887 (review) When we look at this, we can see both that the reviewer has done a thorough job checking the PR, and the reviewee has done their job in creating the PR.

@pdimaano pdimaano self-requested a review May 28, 2024 17:54
@pdimaano
Copy link
Member

ETA: 5/31/24
Availability: Weekday evenings

@dcotelessa
Copy link
Member

Hi @terrencejihoonjung,

  • a single variable was created "github-handle" under "name" variable" for Conor McKiernan
  • the description contains the issue number and the change, "github-handle" added

Thank you! Great job!

Copy link
Member

@pdimaano pdimaano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrencejihoonjung Good job: The branches are correct and the issue is linked. The webpage is visually unchanged on desktop, mobile and tablet. The correct file was updated with the requested information. Well done!

Copy link
Member

@del9ra del9ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @terrencejihoonjung,

  • The pull request is done with the correct branch
  • The issue is properly linked
  • The PR clearly tells us what changes were made and why
  • No visual changes were performed
    Excellent work! Good job!

@del9ra
Copy link
Member

del9ra commented May 30, 2024

ETA: 5/30/2024
Availability: 1-4 PM Friday

@jphamtv jphamtv merged commit f515656 into hackforla:gh-pages May 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github-handle for Conor McKiernan in ems-triage-tracker.md
6 participants