-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added github-handle for Conor McKiernan #6897
Added github-handle for Conor McKiernan #6897
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Hi @dcotelessa Here is an example of a well-done review: #6887 (review) When we look at this, we can see both that the reviewer has done a thorough job checking the PR, and the reviewee has done their job in creating the PR. |
ETA: 5/31/24 |
Thank you! Great job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terrencejihoonjung Good job: The branches are correct and the issue is linked. The webpage is visually unchanged on desktop, mobile and tablet. The correct file was updated with the requested information. Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The pull request is done with the correct branch
- The issue is properly linked
- The PR clearly tells us what changes were made and why
- No visual changes were performed
Excellent work! Good job!
ETA: 5/30/2024 |
Fixes #6722
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Screenshots of Proposed Changes Of The Website