Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub handle Ryan Mayott #6852

Merged
merged 2 commits into from
May 16, 2024

Conversation

santisecco
Copy link
Member

Fixes #6732

What changes did you make?

  • Under "- name: Ryan Mayott" I added "github-handle:"

Why did you make the changes (we will use this info to test)?

  • To create a single variable github-handle to hold the github handle for Ryan Mayott

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b santisecco-add-github-handle-6732 gh-pages
git pull https://github.com/santisecco/website.git add-github-handle-6732

@github-actions github-actions bot added Status: Help Wanted Internal assistance is required to make progress good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 13, 2024
@santisecco santisecco self-assigned this May 13, 2024
@santisecco santisecco removed the Status: Help Wanted Internal assistance is required to make progress label May 13, 2024
@urvishp13 urvishp13 self-requested a review May 14, 2024 16:40
@urvishp13
Copy link
Member

Review ETA: EOD
Availability: 1pm - 4pm 5/14/24

@urvishp13
Copy link
Member

Blocker: it seems like there is a merge happening in the commit history from the gh-pages branch. This stood out to me as odd. Is it okay to have this?

@urvishp13 urvishp13 added the Status: Help Wanted Internal assistance is required to make progress label May 14, 2024
@tony1ee
Copy link
Member

tony1ee commented May 14, 2024

Hi @urvishp13, the merge from gh-pages seemed to be the result of incorporating changes from upstream, there's no additional file changes from that merge as seen in https://github.com/hackforla/website/pull/6852/files

The merge commit should not be an issue for approval.

The merge team likely will squash merge this PR so that merge commit won't show up in gh-pages branch commit history.

Hope this helps.

@urvishp13
Copy link
Member

Okay thanks @tony1ee

@urvishp13 urvishp13 removed the Status: Help Wanted Internal assistance is required to make progress label May 14, 2024
Copy link
Member

@urvishp13 urvishp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @santisecco! Great job completing this issue!

  • pull request done on the correct branch
  • correctly linked issue
  • good job making sure to use spaces instead of tabs in the source code
  • no visual changes done to the website in desktop, tablet, and mobile views (Firefox, Chrome)

@roslynwythe roslynwythe requested a review from DrAcula27 May 15, 2024 02:19
@DrAcula27
Copy link
Member

Review ETA: 15 May 2024
Availability: weekdays, 2pm – 8pm Pacific Time

Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santisecco Great job on your Good First Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file _projects/engage.md was edited
  • No extra edits were made
  • Spaces were used instead of tabs for indenting
  • Appearance of the website is unchanged (Chrome and Firefox)

@jphamtv jphamtv merged commit e75949f into hackforla:gh-pages May 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github-handle for Ryan Mayott in engage.md
5 participants