-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub handle Ryan Mayott #6852
Add GitHub handle Ryan Mayott #6852
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD |
Blocker: it seems like there is a merge happening in the commit history from the |
Hi @urvishp13, the merge from The merge commit should not be an issue for approval. The merge team likely will squash merge this PR so that merge commit won't show up in Hope this helps. |
Okay thanks @tony1ee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @santisecco! Great job completing this issue!
- pull request done on the correct branch
- correctly linked issue
- good job making sure to use spaces instead of tabs in the source code
- no visual changes done to the website in desktop, tablet, and mobile views (Firefox, Chrome)
Review ETA: 15 May 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@santisecco Great job on your Good First Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/engage.md
was edited - No extra edits were made
- Spaces were used instead of tabs for indenting
- Appearance of the website is unchanged (Chrome and Firefox)
Fixes #6732
What changes did you make?
Why did you make the changes (we will use this info to test)?
github-handle
to hold the github handle for Ryan MayottScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes