Refactored JavaScript files so that Events page sources meeting data from vrms_data.json

[irais-valenzuela]

Fixes #6023

What changes did you make?

• Created a new file in assets/js/utility called vrms-events.js to handle data fetching from the vrms_data.json file, vrms data sorting, and vrms data formatting for both project.html and right-col-content.html page.
• The project.js file no longer has sorting and time formatting functions sortByDate and timeFormat as they were moved to vrms-events.js file and timeFormat was replaced with localeTimeIn12Format. Project.js still uses sortByDate and formatting functions but they're are now coming from vrms-events.js.
• The right-col-content.js file now has the insertEventSchedule functionality that used to live in api-events.js. As well as other functions that used to be in api-events.js.
• Api-events.js is no longer being used for right-col-content.js to grab event data so most of that file is commented out.
• In summary, both project.html and right-col-content.html now share data fetching, sorting, and formatting functionality.

Why did you make the changes (we will use this info to test)?

• Needed to reduce the latency and improve the reliability of the Events page and leverage the vrms_data.json file that already had event data to render meeting times for events page.
• Both project.html and right-col-content.html had data fetching, sorting, and formatting logic that could be shared by both files.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

No changes to website.

Visuals after changes are applied

No changes to website.

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b irais-valenzuela-refactor-js-events-page-6023 gh-pages
git pull https://github.com/irais-valenzuela/website.git refactor-js-events-page-6023

[aadilahmed]

Review ETA: EOD 5/7/24
Availability: 9-5 PM M-F

[aadilahmed]

Hi @irais-valenzuela , great job so far, the meeting data on the "events" page matches the live site exactly.

However, the meeting data is blank on the "events-check" page, which I believe is because you commented out the code in api-events.js . To maintain the behavior of the original events page, you should revert api-events.js back to its original code.

[irais-valenzuela]

@aadilahmed Thanks for catching that! I just restored the code. Let me know if everything else is good.

[aadilahmed]

Everything works as expected, great job @irais-valenzuela !

[roslynwythe]

Great job @irais-valenzuela on this Complexity: Large issue!

• Code changes are clean, correct and achieve the desired refactoring
• Pull Request is well-formed with proper branching and description of work
  • The description could be improved slightly by replacing both of the "Visual changes" detail-summary blocks with a single line "no visual changes"
• Local testing of /events-check shows that event list is consistent with the live /events page
• Local testing of /projects/civic-tech-jobs shows that event list is consistent with the live /projects/civic-tech-jobs page
• Local testing of /events shows that event list is consistent with the live /projects/civic-tech-jobs page

Unfortunately in the process of checking events, I discovered discrepancies between the events on pages sourcing data from the API calls versus pages sourcing data from the vrms-data.json file,

• Those will be addressed in ER: discrepancies in meeting data sourced from API calls to VRMS vs. vrms-data.json #6838

Thank you @irais-valenzuela for this contribution to Hack for LA!