Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github-handle for D.Nyasetia #6792

Merged

Conversation

del9ra
Copy link
Member

@del9ra del9ra commented Apr 30, 2024

Fixes #6702

What changes did you make?

  • Added "github-handle:" under "- name: Debbie Nyasetia"

Why did you make the changes (we will use this info to test)?

  • To replace two variables "github" and "picture" variables with one
  • To reduce redundancy

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@del9ra del9ra added good first issue Good for newcomers role: back end/devOps Tasks for back-end developers labels May 1, 2024
@DrAcula27
Copy link
Member

DrAcula27 commented May 1, 2024

ETA for review:

March 2, 2024

Availability:

Weekdays 2pm - 5pm

@ramitaarora
Copy link
Member

ETA: May 1
Availability: Weekdays 9am-12pm

@taylorbeee taylorbeee self-requested a review May 1, 2024 17:45
Copy link
Member

@taylorbeee taylorbeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@del9ra - branch looks good, issue is linked correctly and spaces were used rather than tabs. Great work.

Approved!

Copy link
Member

@ramitaarora ramitaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

  • PR was made from your fork
  • Issue was linked correctly
  • Changes were made correctly

Thank you! Approved. :)

Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@del9ra
Great work on your good first issue!

  • PR was initiated from the correct branch
  • It fixes the linked issue
  • No extra changes were made
  • You used spaces instead of tabs to indent

Approved 😄

@jphamtv jphamtv merged commit 047e7ef into hackforla:gh-pages May 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers role: back end/devOps Tasks for back-end developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github-handle for Debbie Nyasetia in design-systems.md
5 participants