Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused "timelineArray" variable #6708

Merged

Conversation

Jperparas
Copy link
Member

Fixes #6642

What changes did you make?

  • deleted unused variable "timelineArray" in github-actions/trigger-schedule/add-update-label-weekly/add-label.js

Why did you make the changes (we will use this info to test)?

  • To resolve CodeQL alert 53 that referenced an unused variable in github-actions/trigger-schedule/add-update-label-weekly/add-label.js
  • removing unused code helps improve readability and performance

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes, an unused variable was deleted.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Jperparas-resolve-codeql-alert53-6642 gh-pages
git pull https://github.com/Jperparas/website.git resolve-codeql-alert53-6642

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Jperparas/website/blob/resolve-codeql-alert53-6642/CONTRIBUTING.md  

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium size: 1pt Can be done in 4-6 hours Feature: Code Alerts labels Apr 21, 2024
@aidanwsimmons aidanwsimmons self-assigned this Apr 22, 2024
@aidanwsimmons
Copy link
Member

ETA- EOD Monday
Availability- weekday afternoons

@aidanwsimmons aidanwsimmons self-requested a review April 22, 2024 00:15
@aidanwsimmons aidanwsimmons removed their assignment Apr 22, 2024
@JackCasica JackCasica self-requested a review April 22, 2024 04:34
@JackCasica
Copy link
Member

Hi ~ I'll be reviewing this PR tomorrow ~
Availability: (04/22)
ETA: EOD (04/22)

Copy link
Member

@aidanwsimmons aidanwsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jperparas-

  • branch naming done properly
  • issue correctly linked
  • changes align with your recommendation for the codeql alert resolution
  • summaries are clear and concise

Nice job -Approved!

@JackCasica
Copy link
Member

Hi ~ In this PR, you...

image

PR Approved!

@freaky4wrld freaky4wrld merged commit 549a963 into hackforla:gh-pages Apr 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Code Alerts role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve CodeQL alert 53
4 participants