Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved CodeQL Alert 50 by removing unused variable. #6660

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

danajeon
Copy link
Member

Fixes #6621

What changes did you make?

  • Removed unused variable contactMessage.

Why did you make the changes (we will use this info to test)?

  • Change was made because variable is unused, which may lead to performance issues due to wasted computation.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Modified api-actionnetwork.js file. No visual changes made to website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b danajeon-resolve-codeql-alert-6621 gh-pages
git pull https://github.com/danajeon/website.git resolve-codeql-alert-6621

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/danajeon/website/blob/resolve-codeql-alert-6621/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium size: 1pt Can be done in 4-6 hours ready for product Feature: Code Alerts labels Apr 17, 2024
@roslynwythe roslynwythe self-requested a review April 21, 2024 17:21
@roslynwythe
Copy link
Member

@danajeon The modified code is used to respond to form submissions on the /Join page. Using the issue branch from this PR, I submitted forms and am attempting to confirm receipt of the email messages.

@ExperimentsInHonesty
Copy link
Member

@roslynwythe The original issue for this is here

  • Create website routes to survey forms #316
  • We need an ER
    • The forms and the spreadsheet, etc will need to be moved by me, and we should discuss how we test in future, which will inform the setup.
    • the info all should get documented in our wiki.

@ExperimentsInHonesty
Copy link
Member

@roslynwythe I checked and we got all the form submissions you did.

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @danajeon on this issue:

  • The analysis and code change are correct
  • The PR is well-formed and descriptive
  • The changes were tested by confirming that the forms on the Join Us page result in email messages

@roslynwythe roslynwythe merged commit 910f724 into hackforla:gh-pages Apr 23, 2024
10 checks passed
@danajeon danajeon deleted the resolve-codeql-alert-6621 branch April 23, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Code Alerts ready for product role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve CodeQL Alert 50
3 participants