Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github handle to Benny Van section #6657

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Cloid
Copy link
Member

@Cloid Cloid commented Apr 16, 2024

Fixes #6124

What changes did you make?

  • Added additional var called github-handle

Why did you make the changes (we will use this info to test)?

  • Changes were already made in the requirements.github-handle will eventually be used deprecate redundant variables and have one singular variable to replace them.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied image
Visuals after changes are applied image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Cloid-add-github-handle-6124 gh-pages
git pull https://github.com/Cloid/hackforla_website.git add-github-handle-6124

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Cloid/website/blob/add-github-handle-6124/CONTRIBUTING.md  

@Cloid Cloid added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 16, 2024
@iancooperman iancooperman self-requested a review April 17, 2024 02:05
@iancooperman
Copy link
Member

ETA: 4/17 EoD
Availability: 4/16 - 7 to 9pm, 4/17 5 to 9pm

Copy link
Member

@iancooperman iancooperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just make sure to check off the appropriate action items on the original issue. Thanks for contributing!

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Cloid - Thanks for working on this issue!

  • Pull request done with correct branch
  • Issue properly linked
  • Clear summary of changes
  • Code correctly uses spaces for indentation

For future issues, if there are no visual changes to the website, comment "No visual changes to website" in place of the before/after screenshots section. Also, check the Action Items on the issue as you complete them.

Great work!

@jphamtv jphamtv removed the request for review from Anahisv23 April 18, 2024 22:19
@jphamtv jphamtv merged commit 8637311 into hackforla:gh-pages Apr 18, 2024
9 of 10 checks passed
@Cloid Cloid deleted the add-github-handle-6124 branch April 19, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github-handle for Benny Van in civic-tech-jobs.md
3 participants