-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added github handle to Benny Van section #6657
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
ETA: 4/17 EoD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just make sure to check off the appropriate action items on the original issue. Thanks for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Cloid - Thanks for working on this issue!
- Pull request done with correct branch
- Issue properly linked
- Clear summary of changes
- Code correctly uses spaces for indentation
For future issues, if there are no visual changes to the website, comment "No visual changes to website" in place of the before/after screenshots section. Also, check the Action Items on the issue as you complete them.
Great work!
Fixes #6124
What changes did you make?
github-handle
Why did you make the changes (we will use this info to test)?
github-handle
will eventually be used deprecate redundant variables and have one singular variable to replace them.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied