Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CONTRIBUTING.md Section 1.7 #6547

Merged

Conversation

gdkoo
Copy link
Member

@gdkoo gdkoo commented Mar 29, 2024

Fixes #6450

What changes did you make?

  • Removed duplicate instance of Section 1.7 in CONTRIBUTING.md

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changes were made to Github guide for developers. No changes to website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b gdkoo-update-contributing.md-section-1.7-6450 gh-pages
git pull https://github.com/gdkoo/website.git update-contributing.md-section-1.7-6450

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/gdkoo/website/blob/update-contributing.md-section-1.7-6450/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Mar 29, 2024
@roslynwythe roslynwythe self-requested a review March 29, 2024 09:11
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @gdkoo. You made a clean, correct code change, setup the pull request branches correctly, described your work and provided a preview URL for the convenience of reviewers. Thank you!

@ajb176 ajb176 self-requested a review March 29, 2024 20:06
Copy link
Member

@ajb176 ajb176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look to be exactly as requested, nice work @gdkoo

@freaky4wrld freaky4wrld merged commit 13c5998 into hackforla:gh-pages Mar 30, 2024
10 checks passed
freaky4wrld pushed a commit to freaky4wrld/website that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md Section 1.7
4 participants