Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github-handle to member Leah Ellis in civic-tech-jobs.md #6533

Conversation

duojet2ez
Copy link
Member

Fixes #6110

What changes did you make?

In _projects/civic-tech-jobs.md I replaced:

- name: Leah Ellis

with:

- name: Leah Ellis github-handle:

Why did you make the changes (we will use this info to test)?

This was done in order to have an added variable called 'github handle' for leadership team member Leah Ellis.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b duojet2ez-add-new-variable-github-handle-leahEllis-6110 gh-pages
git pull https://github.com/duojet2ez/website.git add-new-variable-github-handle-leahEllis-6110

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/duojet2ez/website/blob/add-new-variable-github-handle-leahEllis-6110/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 27, 2024
Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

  • The branches are correct and the issue is linked.
  • The correct file was changed with the correct information.
  • I have inspected and confirmed no visible changes in developer mode on Chrome (desktop, tablet, and mobile view), Firefox, and Safari browser.

Going forward, please summarize the "What changes did you make?" in a sentence instead of copying the code block.

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @duojet2ez - Thanks for working on this issue. Your code change is clean, accurate, and correctly uses spaces. Great work!

@freaky4wrld freaky4wrld merged commit fa55f45 into hackforla:gh-pages Mar 30, 2024
10 checks passed
freaky4wrld pushed a commit to freaky4wrld/website that referenced this pull request Apr 9, 2024
@duojet2ez duojet2ez deleted the add-new-variable-github-handle-leahEllis-6110 branch September 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Leah Ellis in civic-tech-jobs.md
4 participants