-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change single quotes to double quotes in order to resolve linter error #6360
change single quotes to double quotes in order to resolve linter error #6360
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branches are correct and the issue is linked.
The correct file was changed with the correct information.
I have inspected and confirmed the changes in my local IDE.
Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aconstas,
- The pull request is done with the correct branch
- The issue is properly linked
- Your summary of changes is clear and helpful
Please revert the change on line 45, and remove the second bullet point from the "Why did you make changes" section. Although correct, please limit your changes to the scope of the issue. "Good first issues" typically involve single line/item updates to ease into our process. The update for line 45 is covered in another issue (#5710).
After making the change, please re-request reviews using the circular arrows icon next to the reviewers' names.
Thanks!
@jphamtv My apologies! That's good to know, thank you for the insight. I will update the PR now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aconstas - Thanks for the update and great work! PR approved.
Please re-request a review by clicking the circular arrows icon next to the reviewer's name to get the second approval needed for merging.
@jphamtv Done. :) |
@aconstas, the issue is updated as requested, the issue is linked properly, and the pull request summary is detailed. Nice job. |
Fixes #5711
What changes did you make?
anchor
class andFAQ
id.Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes made to the site.