Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change single quotes to double quotes in order to resolve linter error #6360

Merged

Conversation

aconstas
Copy link
Member

@aconstas aconstas commented Feb 23, 2024

Fixes #5711

What changes did you make?

  • Changed single quotes to double quotes for anchor class and FAQ id.

Why did you make the changes (we will use this info to test)?

  • Per issue: "We want to update an HTML tag to resolve the linter error "Value of attribute [class] must be in double quotes""

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes made to the site.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aconstas-refactor-html-linter-error-5711 gh-pages
git pull https://github.com/aconstas/website.git refactor-html-linter-error-5711

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/aconstas/website/blob/refactor-html-linter-error-5711/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 23, 2024
@jtw007 jtw007 requested review from jtw007 and removed request for jtw007 February 23, 2024 01:13
jtw007
jtw007 previously approved these changes Feb 23, 2024
Copy link
Member

@jtw007 jtw007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branches are correct and the issue is linked.
The correct file was changed with the correct information.
I have inspected and confirmed the changes in my local IDE.

Nice job!

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aconstas,

  • The pull request is done with the correct branch
  • The issue is properly linked
  • Your summary of changes is clear and helpful

Please revert the change on line 45, and remove the second bullet point from the "Why did you make changes" section. Although correct, please limit your changes to the scope of the issue. "Good first issues" typically involve single line/item updates to ease into our process. The update for line 45 is covered in another issue (#5710).

After making the change, please re-request reviews using the circular arrows icon next to the reviewers' names.

Thanks!

@aconstas
Copy link
Member Author

@jphamtv My apologies! That's good to know, thank you for the insight. I will update the PR now :)

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aconstas - Thanks for the update and great work! PR approved.

Please re-request a review by clicking the circular arrows icon next to the reviewer's name to get the second approval needed for merging.

Screenshot 2024-02-24 at 10 25 57

@aconstas aconstas requested a review from jtw007 February 24, 2024 19:15
@aconstas
Copy link
Member Author

@jphamtv Done. :)

@drakenguyen4000
Copy link
Member

@aconstas, the issue is updated as requested, the issue is linked properly, and the pull request summary is detailed. Nice job.

@drakenguyen4000 drakenguyen4000 merged commit 14a1168 into hackforla:gh-pages Feb 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor HTML to resolve linter error: _guidepages/2FA.html - line 46
4 participants