Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img Tag Refactor: Join Us Page - advice-us-icon.svg #6302

Merged

Conversation

luisitocanlas
Copy link
Member

Fixes #5148

What changes did you make?

  • Removed the ending slash in the img HTML tag at line 87.

Why did you make the changes (we will use this info to test)?

  • So that the codebase is consistent with how img HTML tags are used.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b luisitocanlas-img-tag-refactor-5148 gh-pages
git pull https://github.com/luisitocanlas/website.git img-tag-refactor-5148

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/luisitocanlas/website/blob/img-tag-refactor-5148/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Join Page https://www.hackforla.org/join Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 16, 2024
@danvgar danvgar self-requested a review February 19, 2024 01:43
Copy link
Member

@danvgar danvgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes Issue #5148

Branch is correct. Code looks good and in Docker.

No visual changes.

Great work, @luisitocanlas !!

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @luisitocanlas Great job on your first issue!

  • branches are correct,
  • the original issue is linked,
  • there is a concise description of what changes were made and why,
  • there are no visual changes so the notes are removed, and
  • the code changes are clean
    Perfect- thanks for your contribution

@t-will-gillis t-will-gillis merged commit 8d03bed into hackforla:gh-pages Feb 19, 2024
10 checks passed
@luisitocanlas luisitocanlas deleted the img-tag-refactor-5148 branch February 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Join Page https://www.hackforla.org/join role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Join Us Page - advice-us-icon.svg
3 participants