Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve codeql 6053 #6287

Closed
wants to merge 4 commits into from

Conversation

junadkat32
Copy link
Member

@junadkat32 junadkat32 commented Feb 13, 2024

Fixes #6053

What changes did you make?

Replaced <a href='{{ leader.links.linkedin }}' target='_blank' title='Linkedin Profile'>

with

<a href='{{ leader.links.linkedin }}' target='_blank' title='Linkedin Profile' rel="noopener noreferrer">

Why did you make the changes (we will use this info to test)?

To resolve codeql alert 6053

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b junadkat32-resolve-codeql-6053 gh-pages
git pull https://github.com/junadkat32/website.git resolve-codeql-6053

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/junadkat32/website/blob/resolve-codeql-6053/CONTRIBUTING.md  

@junadkat32 junadkat32 added good first issue Good for newcomers Feature: Code Alerts P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 13, 2024
@Thinking-Panda Thinking-Panda self-requested a review February 13, 2024 20:51
@Thinking-Panda
Copy link
Member

Availability: Weekdays
Review ETA:2/13/24

Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junadkat32 , Thank you for working on this issue. Merge branches are setup correctly. The action item in the issue mentions to add the rel= attribute only for the LinkedIn Profile on line 54. Please reverse changes made to line 58. There will probably be another issue to make that change. Thanks!

@junadkat32
Copy link
Member Author

@Thinking-Panda Yes, you are right. There is a separate issue for line 58and it was me who took up that issue and the PR has been approved. Please advise on further steps.

Thank you.

@Thinking-Panda
Copy link
Member

@Thinking-Panda Yes, you are right. There is a separate issue for line 58and it was me who took up that issue and the PR has been approved. Please advise on further steps.

Thank you.

@junadkat32 , developers are expected to work on only one issue at a time and wait until the previous issue is merged to pick another issue. We need to check with the merge-team on further steps.

@roslynwythe
Copy link
Member

@junadkat32 This PR will be closed, because you are assigned to a different open issue.

@junadkat32
Copy link
Member Author

Hello @roslynwythe my previous PR was merged and I have reopened this PR.

@junadkat32 junadkat32 self-assigned this Feb 20, 2024
@t-will-gillis
Copy link
Member

Hey @junadkat32 - Closing this PR for a couple of reasons: first is that although you were previously, you are not currently assigned to this issue which is required for opening the PR. The other reason is that you have already completed 3 good first issues and, as is noted on the "Pre-work Checklist", you should be advancing to a Complexity: Small issue. Thanks!

@junadkat32 junadkat32 removed their assignment Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Code Alerts good first issue Good for newcomers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve CodeQL alert 19 "Potentially unsafe external link"
4 participants