-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve codeql 6053 #6287
Resolve codeql 6053 #6287
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Availability: Weekdays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junadkat32 , Thank you for working on this issue. Merge branches are setup correctly. The action item in the issue mentions to add the rel=
attribute only for the LinkedIn Profile on line 54
. Please reverse changes made to line 58
. There will probably be another issue to make that change. Thanks!
@Thinking-Panda Yes, you are right. There is a separate issue for Thank you. |
@junadkat32 , developers are expected to work on only one issue at a time and wait until the previous issue is merged to pick another issue. We need to check with the merge-team on further steps. |
@junadkat32 This PR will be closed, because you are assigned to a different open issue. |
Hello @roslynwythe my previous PR was merged and I have reopened this PR. |
Hey @junadkat32 - Closing this PR for a couple of reasons: first is that although you were previously, you are not currently assigned to this issue which is required for opening the PR. The other reason is that you have already completed 3 |
Fixes #6053
What changes did you make?
Replaced
<a href='{{ leader.links.linkedin }}' target='_blank' title='Linkedin Profile'>
with
<a href='{{ leader.links.linkedin }}' target='_blank' title='Linkedin Profile' rel="noopener noreferrer">
Why did you make the changes (we will use this info to test)?
To resolve codeql alert 6053
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes