added rel attribute to anchor tag

[aidanwsimmons]

Fixes #6054

What changes did you make?

• added rel attribute to anchor tag
• changed "" to ''
• Resolve CodeQL alert

Why did you make the changes (we will use this info to test)?

• sole action item

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

N/A

Visuals after changes are applied

N/A

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aidanwsimmons-gh-pages gh-pages
git pull https://github.com/aidanwsimmons/hackForLAwebsite.git gh-pages

---

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/aidanwsimmons/website/blob/gh-pages/CONTRIBUTING.md  

[njackman-2344]

Hey @aidanwsimmons, I see there's a security issue with the code. Try using ' ' instead of "" for rel and see if the security github action goes away. I believe that should clear that up.

So far branches look fine. Issue #6054 is linked (great) but also to leave merge checkbox clear for merge team to check that when they look at issue.

Also if you could please delete the 404 links underneath for consistency: Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes) and if there's no website screenshots associated with the PR, you can put n/a or something similar.

Thanks :)

[gaylem]

Hey @aidanwsimmons, great job deducing the scope of the ticket and implementing the tag!

I second the feedback provided by @njackman-2344 and would only add the following:

1. Be mindful of how you're using markdown in the pull request description. I think you'll need a space between the hyphen (-) and the text to ensure it becomes a bullet point instead of a title. Not a big deal here, but it could cause confusion on larger issues.

2. Under "Why did you make the changes (we will use this info to test)?" it would be helpful to provide more information. Even though it's provided in the story, having a summary of the "why" on the PR makes it easier for the reviewer to understand the purpose. In this case, it's not a big deal because the issue is so small, but it'll be helpful to provide more info for larger stories.

Way to go! I'll take a look again once your changes have been made.

[gaylem]

See comments above

[aidanwsimmons]

Fixes #6054

What changes did you make and why did you make them ?

• added rel attribute to anchor tag
• changes "" to ''
• To resolve CodeQL alert

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

n/a

Visuals after changes are applied

n/a

[gaylem]

Looks good! The error appears to be gone and the markdown is much improved. Great work! :D

[t-will-gillis]

Hey @aidanwsimmons Good job on your first issue. Thanks for working with @gaylem and @njackman-2344 and addressing their comments. Everything is looking good, but I have a couple of additional comments.

• The more minor one is regarding the response to "Why did you make the changes...?" This should be the reason for the original issue. For this issue the third bullet point is a great answer and you could respond with: "To resolve the CodeQL alert." (Note that this section can be edited by selecting the three dots in the upper right of the box.)
• The other comment is regarding your branch. Your gh-pages should be kept free of changes and updated with hackforla:gh-pages, and a new branch should be created whenever you work on a new issue. Please see the following section of CONTRIBUTING.md and other sections for the flow.

You may want or need to start over with a new PR and close this one. When/if you open the new PR, add us as reviewers.

If you have questions, dm me on Slack. Thanks for working on this! It takes a little while to get the hang of GitHub...