Proj filter styling #619
Merged
Proj filter styling #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tyler-project-filter: support for yaml categories from dom parsing, not robust populate from, and propagate to, URL query string move temp styling to scss point filter to github data, hard-coded filter categories cleaning and commenting, minimal initial pass complete initial, needs and/or distinction
…d not have the correct structure for their looking data
…ate filter drop downs
|
Looks excellent. I found on UI issue. If you choose more than one item in a list - and then uncheck one of them, the pink highlight on the dropdown name goes away, even though there are items still checked.
|
|
I've added a counter to address the checkedbox bug, and have removed unused code (when I was still experimenting with the styling in javascript) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #254
Edited styles for Project Filters, and adjusted 'Submit Your Pitch' button on mobile view